Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Side by Side Diff: Source/core/html/HTMLTitleElement.cpp

Issue 143363002: Don't create an empty text node when setting document.title to the empty string (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 82
83 return result.toString(); 83 return result.toString();
84 } 84 }
85 85
86 void HTMLTitleElement::setText(const String &value) 86 void HTMLTitleElement::setText(const String &value)
87 { 87 {
88 RefPtr<Node> protectFromMutationEvents(this); 88 RefPtr<Node> protectFromMutationEvents(this);
89 ChildListMutationScope mutation(*this); 89 ChildListMutationScope mutation(*this);
90 90
91 // Avoid calling Document::setTitleElement() during intermediate steps. 91 // Avoid calling Document::setTitleElement() during intermediate steps.
92 m_ignoreTitleUpdatesWhenChildrenChange = true; 92 m_ignoreTitleUpdatesWhenChildrenChange = !value.isEmpty();
93 removeChildren(); 93 removeChildren();
94 m_ignoreTitleUpdatesWhenChildrenChange = false; 94 m_ignoreTitleUpdatesWhenChildrenChange = false;
95 95
96 appendChild(document().createTextNode(value.impl()), IGNORE_EXCEPTION); 96 if (!value.isEmpty())
97 appendChild(document().createTextNode(value.impl()), IGNORE_EXCEPTION);
97 } 98 }
98 99
99 } 100 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698