Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 143363002: Don't create an empty text node when setting document.title to the empty string (Closed)

Created:
6 years, 11 months ago by davve
Modified:
6 years, 11 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Don't create an empty text node when setting document.title to the empty string http://www.whatwg.org/specs/web-apps/current-work/#document.title http://www.whatwg.org/specs/web-apps/current-work/#the-title-element now both refer to: http://dom.spec.whatwg.org/#dom-node-textcontent for how the empty string should handled: empty string -> no child element. Note that the act of updating the document's copy of the title then falls on the removeChildren() call. Since FF and IE10 already follows the spec, web compatibility risk should be small. BUG=336154 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165453

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix indentation in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
A LayoutTests/fast/dom/document-set-title-no-child-on-empty.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/document-set-title-no-child-on-empty-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTitleElement.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
davve
One more little document.title patch, Jochen. Follow-up to https://groups.google.com/a/chromium.org/d/msg/blink-dev/ONBQQ5uhBik/k69txD96l5sJ I think we're pretty much spec ...
6 years, 11 months ago (2014-01-20 14:43:49 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/143363002/diff/1/LayoutTests/fast/dom/document-set-title-no-child-on-empty.html File LayoutTests/fast/dom/document-set-title-no-child-on-empty.html (right): https://codereview.chromium.org/143363002/diff/1/LayoutTests/fast/dom/document-set-title-no-child-on-empty.html#newcode5 LayoutTests/fast/dom/document-set-title-no-child-on-empty.html:5: <script> nit 4 spaces indent
6 years, 11 months ago (2014-01-20 19:22:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/143363002/60001
6 years, 11 months ago (2014-01-21 10:16:02 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-21 11:12:46 UTC) #4
Message was sent while issue was closed.
Change committed as 165453

Powered by Google App Engine
This is Rietveld 408576698