Add ProcessMetrics::CreateCurrentProcessMetrics() method.

Add ProcessMetrics::CreateCurrentProcessMetrics() method.

Code that creates a ProcessMetrics object can be confusing because
ProcessMetrics::CreateProcessMetrics() has a different signature on Mac.
The extra Mac parameter isn't required when creating a ProcessMetrics
object for the current process (which is a common thing to do).

To allow simplification of code that creates a ProcessMetrics object
for the current process, this CL introduces a new
ProcessMetrics::CreateCurrentProcessMetrics() method, which has the
same signature on all platforms.

BUG=553266
Committed: https://crrev.com/28787424acfc81f458824812a35c67d461b84035
Cr-Commit-Position: refs/heads/master@{#359199}

[fdoray, 2015-11-09 04:32:30]

fdoray@chromium.org changed reviewers:
+ thestig@chromium.org

[fdoray, 2015-11-09 04:32:31]

Could you review this CL? Thanks.

[Lei Zhang, 2015-11-09 19:24:51]

Can any current CreateCurrentProcessMetrics() callers be converted to the new
version? If so, might as well do it in the current CL.

Which version of CreateCurrentProcessMetrics() do you expect to be the more
commonly used case? Put that one on top in the header file.

https://codereview.chromium.org/1433603004/diff/1/base/process/process_metric...
File base/process/process_metrics.cc (right):

https://codereview.chromium.org/1433603004/diff/1/base/process/process_metric...
base/process/process_metrics.cc:50: return
CreateProcessMetrics(base::GetCurrentProcessHandle(), NULL);
NULL -> nullptr in new code please.

https://codereview.chromium.org/1433603004/diff/1/base/process/process_metrics.h
File base/process/process_metrics.h (right):

https://codereview.chromium.org/1433603004/diff/1/base/process/process_metric...
base/process/process_metrics.h:113: // Creates a ProcessMetrics for the current
process.
Maybe mention this is just a cross-platform convenience wrapper.

[fdoray, 2015-11-10 19:30:26]

fdoray@chromium.org changed reviewers:
+ sievers@chromium.org

[fdoray, 2015-11-10 19:30:27]

thestig@: All done. Could you take another look at base/ and chrome/? Thanks.

sievers@: Could you review content/? Thanks.

https://codereview.chromium.org/1433603004/diff/1/base/process/process_metric...
File base/process/process_metrics.cc (right):

https://codereview.chromium.org/1433603004/diff/1/base/process/process_metric...
base/process/process_metrics.cc:50: return
CreateProcessMetrics(base::GetCurrentProcessHandle(), NULL);
On 2015/11/09 19:24:51, Lei Zhang wrote:
> NULL -> nullptr in new code please.

Done.

https://codereview.chromium.org/1433603004/diff/1/base/process/process_metrics.h
File base/process/process_metrics.h (right):

https://codereview.chromium.org/1433603004/diff/1/base/process/process_metric...
base/process/process_metrics.h:113: // Creates a ProcessMetrics for the current
process.
On 2015/11/09 19:24:51, Lei Zhang wrote:
> Maybe mention this is just a cross-platform convenience wrapper.

Done.

[Lei Zhang, 2015-11-10 22:02:29]

lgtm

https://codereview.chromium.org/1433603004/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_database.cc (right):

https://codereview.chromium.org/1433603004/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_database.cc:1433:
ProcessMetrics::CreateCurrentProcessMetrics());
base:: ?

https://codereview.chromium.org/1433603004/diff/20001/content/child/blink_pla...
File content/child/blink_platform_impl.cc (right):

https://codereview.chromium.org/1433603004/diff/20001/content/child/blink_pla...
content/child/blink_platform_impl.cc:1257: using base::ProcessMetrics;
meh, you can omit this line and add base:: below.

[fdoray, 2015-11-11 22:04:38]

thestig@: All done. Thanks for the review.
sievers@: Can you review content/?

https://codereview.chromium.org/1433603004/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_database.cc (right):

https://codereview.chromium.org/1433603004/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_database.cc:1433:
ProcessMetrics::CreateCurrentProcessMetrics());
On 2015/11/10 22:02:29, Lei Zhang wrote:
> base:: ?

Done.

https://codereview.chromium.org/1433603004/diff/20001/content/child/blink_pla...
File content/child/blink_platform_impl.cc (right):

https://codereview.chromium.org/1433603004/diff/20001/content/child/blink_pla...
content/child/blink_platform_impl.cc:1257: using base::ProcessMetrics;
On 2015/11/10 22:02:29, Lei Zhang wrote:
> meh, you can omit this line and add base:: below.

Done.

[no sievers, 2015-11-11 22:10:46]

On 2015/11/11 22:04:38, fdoray wrote:
> thestig@: All done. Thanks for the review.
> sievers@: Can you review content/?
> 
lgtm

[fdoray, 2015-11-11 22:16:59]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2015-11-11 22:16:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1433603004/#ps80001
(title: "Remove patch dependency")

[commit-bot: I haz the power, 2015-11-11 22:18:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1433603004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1433603004/80001

[commit-bot: I haz the power, 2015-11-11 22:39:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-11 22:39:55]

Exceeded global retry quota

[fdoray, 2015-11-11 23:39:51]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2015-11-11 23:41:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1433603004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1433603004/80001

[commit-bot: I haz the power, 2015-11-12 01:12:39]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-12 20:02:19]

Patchset 5 (id:??) landed as
https://crrev.com/28787424acfc81f458824812a35c67d461b84035
Cr-Commit-Position: refs/heads/master@{#359199}