Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 14336011: Disable CanSetupAudioAndVideoCallWithoutMsidAndBundle. (Closed)

Created:
7 years, 8 months ago by not at google - send to devlin
Modified:
7 years, 8 months ago
Reviewers:
perkj_chrome, gab
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Disable CanSetupAudioAndVideoCallWithoutMsidAndBundle. TBR=perkj@chromium.org BUG=235089 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196186

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M content/browser/media/webrtc_browsertest.cc View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
gab
https://codereview.chromium.org/14336011/diff/1/content/browser/media/webrtc_browsertest.cc File content/browser/media/webrtc_browsertest.cc (right): https://codereview.chromium.org/14336011/diff/1/content/browser/media/webrtc_browsertest.cc#newcode120 content/browser/media/webrtc_browsertest.cc:120: DISABLED_CanSetupAudioAndVideoCallWithoutMsidAndBundle) { Only needs to be disable on Win7Aura ...
7 years, 8 months ago (2013-04-24 17:55:04 UTC) #1
gab
Oh and I think disabled tests should be P1 (I think) and have the appropriate ...
7 years, 8 months ago (2013-04-24 17:57:04 UTC) #2
not at google - send to devlin
Sure, I just don't know what label it should be. But i'll mark it p1. ...
7 years, 8 months ago (2013-04-24 17:58:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/14336011/5001
7 years, 8 months ago (2013-04-24 17:59:11 UTC) #4
gab
LGTM, for the labels I just searched for "Media" and "WebRTC" labels and used those, ...
7 years, 8 months ago (2013-04-24 18:03:57 UTC) #5
not at google - send to devlin
7 years, 8 months ago (2013-04-24 18:24:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r196186.

Powered by Google App Engine
This is Rietveld 408576698