Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4603)

Unified Diff: scripts/master/try_job_base.py

Issue 14336002: Let Blink try jobs use a Blink-specific LKGR (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: fix bug # Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « masters/master.tryserver.chromium/master.cfg ('k') | site_config/config_default.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/try_job_base.py
diff --git a/scripts/master/try_job_base.py b/scripts/master/try_job_base.py
index 38af40d988f47003d0892163eb72672653e269e9..8cccd3b30f06f459b13d9167e3bf2194ad384ff4 100644
--- a/scripts/master/try_job_base.py
+++ b/scripts/master/try_job_base.py
@@ -261,7 +261,15 @@ class TryJobBase(TryBase):
def get_lkgr(self, options):
"""Grabs last known good revision number if necessary."""
options['rietveld'] = (self.code_review_sites or {}).get(options['project'])
- last_good_url = (self.last_good_urls or {}).get(options['project'])
+
+ # TODO: crbug.com/233418 - Only use the blink url for jobs with the blink
+ # project set. This will require us to always set the project in blink
+ # configs.
+ project = options['project']
+ if project == 'chrome' and all('_layout_' in bot for bot in options['bot']):
+ project = 'blink'
+ last_good_url = (self.last_good_urls or {}).get(project)
+
if options['revision'] or not last_good_url:
return defer.succeed(0)
« no previous file with comments | « masters/master.tryserver.chromium/master.cfg ('k') | site_config/config_default.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698