Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 14336002: Let Blink try jobs use a Blink-specific LKGR (Closed)

Created:
7 years, 8 months ago by Dirk Pranke
Modified:
7 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, xusydoc+watch_chromium.org, cmp-cc_chromium.org, ilevy+cc_chromium.org, kjellander+cc_chromium.org, Mike Stip (use stip instead), M-A Ruel, cmp, szager1
Visibility:
Public.

Description

Let Blink try jobs use a Blink-specific LKGR. Currently we're using mostly the same code for blink try jobs and chromium try jobs. We have hardcoded logic to use the blink HEAD revision for jobs run on the *_layout_* bots, but use the chromium LKGR revision for all bots. This is not a good configuration to be using. Ultimately we should have a blink LKGR that specifies revisions of both blink and chromium, and have a way to tell try jobs that they are blink changes. This change is a step along that path, in that we'll start using blink-status.appspot.com/lkgr to pull a chromium revision, which is set manually for now. Later changes will add a blink-specific lkgr_finder that does something more correct. R=iannucci@chromium.org BUG=233418 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=195040

Patch Set 1 #

Patch Set 2 : clean up #

Total comments: 1

Patch Set 3 : fix bug # #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M masters/master.tryserver.chromium/master.cfg View 1 1 chunk +2 lines, -1 line 0 comments Download
M scripts/master/try_job_base.py View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M site_config/config_default.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
7 years, 8 months ago (2013-04-19 00:26:19 UTC) #1
iannucci
Copy the subject into the description :) https://codereview.chromium.org/14336002/diff/2001/scripts/master/try_job_base.py File scripts/master/try_job_base.py (right): https://codereview.chromium.org/14336002/diff/2001/scripts/master/try_job_base.py#newcode265 scripts/master/try_job_base.py:265: # TODO: ...
7 years, 8 months ago (2013-04-19 00:36:20 UTC) #2
iannucci
besides that lgtm
7 years, 8 months ago (2013-04-19 00:36:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/14336002/9001
7 years, 8 months ago (2013-04-19 01:19:15 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 01:20:12 UTC) #5
Message was sent while issue was closed.
Change committed as 195040

Powered by Google App Engine
This is Rietveld 408576698