ts_mon: removed support for https:// endpoints

ts_mon: removed support for https:// endpoints

Now only support pubsub:// and file:// endpoints.

This allows removing the dependency on monacq completely.

BUG=550648
Committed: https://chromium.googlesource.com/infra/infra/+/5b64cf7742cbf1e18320e3b09f4fc5ca4dca6663

[pgervais, 2015-11-04 23:13:55]

pgervais@chromium.org changed reviewers:
+ dsansome@chromium.org, sergeyberezin@chromium.org

[pgervais, 2015-11-04 23:13:55]

Did some cleanup here, especially in the tests.

PTAL

[Sergey Berezin, 2015-11-04 23:34:26]

LGTM + a couple of nits.

https://chromiumcodereview.appspot.com/1433543003/diff/1/bootstrap/deps.pyl
File bootstrap/deps.pyl (right):

https://chromiumcodereview.appspot.com/1433543003/diff/1/bootstrap/deps.pyl#n...
bootstrap/deps.pyl:1: 
nit: a stray empty line?

https://chromiumcodereview.appspot.com/1433543003/diff/1/infra_libs/ts_mon/te...
File infra_libs/ts_mon/test/config_test.py (right):

https://chromiumcodereview.appspot.com/1433543003/diff/1/infra_libs/ts_mon/te...
infra_libs/ts_mon/test/config_test.py:72: '--ts-mon-endpoint',
'https://www.googleapis.com/some/api'])
This endpoint now is not supported; how does it pass the test?

[pgervais, 2015-11-04 23:48:35]

https://chromiumcodereview.appspot.com/1433543003/diff/1/infra_libs/ts_mon/te...
File infra_libs/ts_mon/test/config_test.py (right):

https://chromiumcodereview.appspot.com/1433543003/diff/1/infra_libs/ts_mon/te...
infra_libs/ts_mon/test/config_test.py:72: '--ts-mon-endpoint',
'https://www.googleapis.com/some/api'])
On 2015/11/04 23:34:25, Sergey Berezin wrote:
> This endpoint now is not supported; how does it pass the test?

Because it falls back to NullMonitor instead of failing. What behavior do you
prefer, failing hard or silently continuing? It's a real question, I'm fine with
both.

[Sergey Berezin, 2015-11-04 23:55:16]

https://chromiumcodereview.appspot.com/1433543003/diff/1/infra_libs/ts_mon/te...
File infra_libs/ts_mon/test/config_test.py (right):

https://chromiumcodereview.appspot.com/1433543003/diff/1/infra_libs/ts_mon/te...
infra_libs/ts_mon/test/config_test.py:72: '--ts-mon-endpoint',
'https://www.googleapis.com/some/api'])
On 2015/11/04 23:48:35, pgervais wrote:
> On 2015/11/04 23:34:25, Sergey Berezin wrote:
> > This endpoint now is not supported; how does it pass the test?
> 
> Because it falls back to NullMonitor instead of failing. What behavior do you
> prefer, failing hard or silently continuing? It's a real question, I'm fine
with
> both.

Silent failure with error log is fine; I wouldn't want to break any services
with monitoring.

My comment was mostly for the test itself; perhaps, if you intend the test to
fall back to NullMonitor, maybe set the endpoint to be obviously unsupported?
(e.g. 'unsupported://api')

[pgervais, 2015-11-05 00:03:43]

Addressed your comments. Thanks for the review!

And committing...

[pgervais, 2015-11-05 00:07:25]

The CQ bit was checked by pgervais@chromium.org

[pgervais, 2015-11-05 00:07:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1433543003/#ps20001
(title: "Fixed nits")

[commit-bot: I haz the power, 2015-11-05 00:07:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1433543003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1433543003/20001

[commit-bot: I haz the power, 2015-11-05 00:08:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 00:08:21]

Try jobs failed on following builders:
  Infra Mac Tester on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/bu...)
  Infra Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Infra%20Presubmit/build...)

[pgervais, 2015-11-05 00:13:04]

The CQ bit was checked by pgervais@chromium.org

[pgervais, 2015-11-05 00:13:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1433543003/#ps40001
(title: "Fixed overzealous cleanup")

[commit-bot: I haz the power, 2015-11-05 00:13:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1433543003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1433543003/40001

[commit-bot: I haz the power, 2015-11-05 00:33:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/5b64cf7742cbf1e18320e3b09f4fc...