Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 1433543002: Fix big-endian after [runtime] Fix ES6 9.2.1 [[Call]] when encountering a classConstructor. (Closed)

Created:
5 years, 1 month ago by paul.l...
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix big-endian after [runtime] Fix ES6 9.2.1 [[Call]] when encountering a classConstructor. Fix typos in big-endian BYTE_OFFSET macro. BUG= Committed: https://crrev.com/532ee45a2f0e2410ea773f8c214d2f002fe120b8 Cr-Commit-Position: refs/heads/master@{#31811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/objects.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
paul.l...
PTAL. This should fix MIPS big-endian bots, and PPC big-endian.
5 years, 1 month ago (2015-11-04 20:55:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433543002/1
5 years, 1 month ago (2015-11-04 20:56:12 UTC) #4
MTBrandyberry
On 2015/11/04 20:55:40, paul.l... wrote: > PTAL. This should fix MIPS big-endian bots, and PPC ...
5 years, 1 month ago (2015-11-04 21:05:02 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-04 21:16:13 UTC) #7
Benedikt Meurer
lgtm
5 years, 1 month ago (2015-11-05 02:45:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433543002/1
5 years, 1 month ago (2015-11-05 02:45:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 02:48:24 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 02:48:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/532ee45a2f0e2410ea773f8c214d2f002fe120b8
Cr-Commit-Position: refs/heads/master@{#31811}

Powered by Google App Engine
This is Rietveld 408576698