[page_load_metrics] Get navigation_start from NavigationHandle

components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/page_load_metrics/browser/metrics_web_contents_observer.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "base/process/kill.h"
 #include "base/test/histogram_tester.h"
 #include "base/time/time.h"
@@ skipping 264 matching lines @@
                                       dom_content.InMilliseconds(), 1);
 
   histogram_tester_.ExpectTotalCount(kHistogramLoad, 1);
   histogram_tester_.ExpectBucketCount(kHistogramLoad, load.InMilliseconds(), 1);
 }
 
 TEST_F(MetricsWebContentsObserverTest, BackgroundDifferentHistogram) {
   base::TimeDelta first_layout = base::TimeDelta::FromSeconds(2);
 
   PageLoadTiming timing;
-  timing.navigation_start = base::Time::FromDoubleT(
-      (base::TimeTicks::Now() - base::TimeTicks::UnixEpoch()).InSecondsF());
+  timing.navigation_start = base::Time::FromDoubleT(1);
   timing.first_layout = first_layout;
 
   content::WebContentsTester* web_contents_tester =
       content::WebContentsTester::For(web_contents());
 
   // Simulate "Open link in new tab."
   observer_->WasHidden();
   web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl));
 
   observer_->OnMessageReceived(
@@ skipping 15 matching lines @@
   histogram_tester_.ExpectTotalCount(kBackgroundHistogramFirstTextPaint, 0);
 
   histogram_tester_.ExpectTotalCount(kHistogramDomContentLoaded, 0);
   histogram_tester_.ExpectTotalCount(kHistogramLoad, 0);
   histogram_tester_.ExpectTotalCount(kHistogramFirstLayout, 0);
   histogram_tester_.ExpectTotalCount(kHistogramFirstTextPaint, 0);
 }
 
 TEST_F(MetricsWebContentsObserverTest, OnlyBackgroundLaterEvents) {
   PageLoadTiming timing;
-  timing.navigation_start = base::Time::FromDoubleT(
-      (base::TimeTicks::Now() - base::TimeTicks::UnixEpoch()).InSecondsF() - 1);
-
-  timing.response_start = base::TimeDelta::FromMilliseconds(1);
-  timing.dom_content_loaded_event_start = base::TimeDelta::FromMilliseconds(1);
+  timing.navigation_start = base::Time::FromDoubleT(1);
+  // Set these events at 1 microsecond so they are definitely occur before we
+  // background the tab later in the test.
+  timing.response_start = base::TimeDelta::FromMicroseconds(1);
+  timing.dom_content_loaded_event_start = base::TimeDelta::FromMicroseconds(1);
 
   content::WebContentsTester* web_contents_tester =
       content::WebContentsTester::For(web_contents());
 
   web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl));
   observer_->OnMessageReceived(
       PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing),
       web_contents()->GetMainFrame());
 
   // Background the tab, then forground it.
@@ skipping 21 matching lines @@
   histogram_tester_.ExpectTotalCount(kHistogramDomContentLoaded, 1);
   histogram_tester_.ExpectBucketCount(
       kHistogramDomContentLoaded,
       timing.dom_content_loaded_event_start.InMilliseconds(), 1);
   histogram_tester_.ExpectTotalCount(kHistogramLoad, 0);
   histogram_tester_.ExpectTotalCount(kHistogramFirstLayout, 0);
   histogram_tester_.ExpectTotalCount(kHistogramFirstTextPaint, 0);
 }
 
 TEST_F(MetricsWebContentsObserverTest, DontBackgroundQuickerLoad) {
-  base::TimeDelta first_layout = base::TimeDelta::FromMilliseconds(1);
+  // Set this event at 1 microsecond so it occurs before we foreground later in
+  // the test.
+  base::TimeDelta first_layout = base::TimeDelta::FromMicroseconds(1);
 
   PageLoadTiming timing;
   timing.navigation_start = base::Time::FromDoubleT(1);
   timing.first_layout = first_layout;
 
   observer_->WasHidden();
 
   // Open in new tab
   content::WebContentsTester* web_contents_tester =
       content::WebContentsTester::For(web_contents());
 
   web_contents_tester->StartNavigation(GURL(kDefaultTestUrl));
 
   content::RenderFrameHostTester* rfh_tester =
       content::RenderFrameHostTester::For(main_rfh());
 
   // Switch to the tab
   observer_->WasShown();
 
   // Start another provisional load
   web_contents_tester->StartNavigation(GURL(kDefaultTestUrl2));
   rfh_tester->SimulateNavigationCommit(GURL(kDefaultTestUrl2));
   observer_->OnMessageReceived(
       PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing),
       main_rfh());
   rfh_tester->SimulateNavigationStop();
 
-  // Navigate again to see if the timing updated for a subframe message.
+  // Navigate again to see if the timing updated for the foregrounded load.
   web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl));
 
   histogram_tester_.ExpectTotalCount(kHistogramDomContentLoaded, 0);
   histogram_tester_.ExpectTotalCount(kHistogramLoad, 0);
   histogram_tester_.ExpectTotalCount(kHistogramFirstLayout, 1);
   histogram_tester_.ExpectBucketCount(kHistogramFirstLayout,
                                       first_layout.InMilliseconds(), 1);
   histogram_tester_.ExpectTotalCount(kHistogramFirstTextPaint, 0);
 }
 
@@ skipping 127 matching lines @@
 
   CheckProvisionalEvent(PROVISIONAL_LOAD_COMMITTED, 2, false);
   CheckCommittedEvent(COMMITTED_LOAD_STARTED, 2, false);
   CheckCommittedEvent(COMMITTED_LOAD_SUCCESSFUL_FIRST_LAYOUT, 1, false);
   CheckTotalEvents();
 }
 
 TEST_F(MetricsWebContentsObserverTest,
        SuccessfulFirstLayoutInBackgroundEvent) {
   PageLoadTiming timing;
-  timing.navigation_start = base::Time::FromDoubleT(
-      (base::TimeTicks::Now() - base::TimeTicks::UnixEpoch()).InSecondsF() - 1);
-
+  timing.navigation_start = base::Time::FromDoubleT(1);
   timing.first_layout = base::TimeDelta::FromSeconds(30);
 
   content::WebContentsTester* web_contents_tester =
       content::WebContentsTester::For(web_contents());
   // Background the tab.
   observer_->WasHidden();
   web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl));
 
   observer_->OnMessageReceived(
       PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing),
@@ skipping 114 matching lines @@
   EXPECT_NE(string_it, sample_obj->string_fields.end());
   EXPECT_EQ(rappor::GetDomainAndRegistrySampleFromGURL(GURL(kDefaultTestUrl)),
             string_it->second);
 
   const auto& flag_it = sample_obj->flag_fields.find("IsSlow");
   EXPECT_NE(flag_it, sample_obj->flag_fields.end());
   EXPECT_EQ(0u, flag_it->second);
 }
 
 }  // namespace page_load_metrics