Add test for CPDF_SyntaxParser::ReadHexString.

core/include/fpdfapi/fpdf_parser.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_INCLUDE_FPDFAPI_FPDF_PARSER_H_
 #define CORE_INCLUDE_FPDFAPI_FPDF_PARSER_H_
 
 #include "../../../public/fpdf_dataavail.h"
@@ skipping 281 matching lines @@
 
   FX_BOOL IsEncrypted() { return m_pCryptoHandler != NULL; }
 
   FX_BOOL GetCharAt(FX_FILESIZE pos, uint8_t& ch);
 
   FX_BOOL ReadBlock(uint8_t* pBuf, FX_DWORD size);
 
   CFX_ByteString GetNextWord(FX_BOOL& bIsNumber);
 
  protected:
+  friend class CPDF_Parser;
+  friend class CPDF_DataAvail;
+
   static const int kParserMaxRecursionDepth = 64;
   static int s_CurrentRecursionDepth;
 
   virtual FX_BOOL GetNextChar(uint8_t& ch);
 
   FX_BOOL GetCharAtBackward(FX_FILESIZE pos, uint8_t& ch);
 
   void GetNextWord();
 
   FX_BOOL IsWholeWord(FX_FILESIZE startpos,
@@ skipping 33 matching lines @@
 
   nonstd::unique_ptr<CPDF_CryptoHandler> m_pCryptoHandler;
 
   uint8_t m_WordBuffer[257];
 
   FX_DWORD m_WordSize;
 
   FX_BOOL m_bIsNumber;
 
   FX_FILESIZE m_dwWordPos;
-  friend class CPDF_Parser;
-  friend class CPDF_DataAvail;
+
+ private:

[Tom Sepez, 2015/11/03 17:41:08]

Is there anything private in this class that the test needs access to?

[dsinclair, 2015/11/03 18:29:49]

Nope, left over from a different path I'd tried originally.

+  friend class fpdf_parser_parser_ReadHexString_Test;
 };
 
 #define PDFPARSE_TYPEONLY 1
 #define PDFPARSE_NOSTREAM 2
 struct PARSE_CONTEXT {
   uint32_t m_Flags;
   FX_FILESIZE m_DictStart;
   FX_FILESIZE m_DictEnd;
   FX_FILESIZE m_DataStart;
   FX_FILESIZE m_DataEnd;
@@ skipping 599 matching lines @@
                        FX_DWORD src_size,
                        const CPDF_Dictionary* pDict,
                        uint8_t*& dest_buf,
                        FX_DWORD& dest_size,
                        CFX_ByteString& ImageEncoding,
                        CPDF_Dictionary*& pImageParms,
                        FX_DWORD estimated_size,
                        FX_BOOL bImageAcc);
 
 #endif  // CORE_INCLUDE_FPDFAPI_FPDF_PARSER_H_