Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1433473003: Ship Harmony ToLength (Closed)

Created:
5 years, 1 month ago by Dan Ehrenberg
Modified:
5 years, 1 month ago
Reviewers:
adamk
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship Harmony ToLength This patch moves ES2015 ToLength semantics on array operations, etc to from staging to shipping. R=adamk BUG=v8:3087 LOG=Y Committed: https://crrev.com/5d44bf026326af7d1d61c399718f9592f561380d Cr-Commit-Position: refs/heads/master@{#31810}

Patch Set 1 #

Patch Set 2 : Fix unit tests #

Patch Set 3 : fix Mozilla test #

Total comments: 2

Patch Set 4 : add --harmony-tolength flag back into tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -223 lines) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download
M test/mjsunit/array-indexing.js View 1 2 chunks +3 lines, -2 lines 0 comments Download
M test/mjsunit/array-length.js View 1 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/array-length.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/es6/regexp-tolength.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
D test/mjsunit/harmony/array-length.js View 1 chunk +0 lines, -202 lines 0 comments Download
D test/mjsunit/harmony/regexp-tolength.js View 1 chunk +0 lines, -19 lines 0 comments Download
M test/mozilla/mozilla.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433473003/1
5 years, 1 month ago (2015-11-03 22:27:30 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/11471)
5 years, 1 month ago (2015-11-03 22:39:15 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433473003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433473003/20001
5 years, 1 month ago (2015-11-04 18:58:45 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/10428)
5 years, 1 month ago (2015-11-04 19:15:43 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433473003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433473003/60001
5 years, 1 month ago (2015-11-04 19:31:51 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-04 20:00:59 UTC) #13
Dan Ehrenberg
5 years, 1 month ago (2015-11-04 20:05:18 UTC) #14
adamk
lgtm, though I'd leave the flag removals out of this patch https://codereview.chromium.org/1433473003/diff/60001/test/mjsunit/es6/array-length.js File test/mjsunit/es6/array-length.js (left): ...
5 years, 1 month ago (2015-11-04 20:08:54 UTC) #15
Dan Ehrenberg
https://codereview.chromium.org/1433473003/diff/60001/test/mjsunit/es6/array-length.js File test/mjsunit/es6/array-length.js (left): https://codereview.chromium.org/1433473003/diff/60001/test/mjsunit/es6/array-length.js#oldcode5 test/mjsunit/es6/array-length.js:5: // Flags: --harmony-tolength On 2015/11/04 at 20:08:54, adamk wrote: ...
5 years, 1 month ago (2015-11-05 00:10:25 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433473003/30008 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433473003/30008
5 years, 1 month ago (2015-11-05 00:10:49 UTC) #18
Dan Ehrenberg
Waiting to submit this until https://codereview.chromium.org/1431503002 is reviewed.
5 years, 1 month ago (2015-11-05 00:11:00 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-05 00:31:52 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433473003/30008 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433473003/30008
5 years, 1 month ago (2015-11-05 00:42:16 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:30008)
5 years, 1 month ago (2015-11-05 00:44:41 UTC) #25
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 00:45:11 UTC) #26
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/5d44bf026326af7d1d61c399718f9592f561380d
Cr-Commit-Position: refs/heads/master@{#31810}

Powered by Google App Engine
This is Rietveld 408576698