Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1433443002: Remove for-in selectors from TreeElements. (Closed)

Created:
5 years, 1 month ago by Johnni Winther
Modified:
5 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove unneeded code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -61 lines) Patch
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +0 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 2 chunks +0 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 1 2 chunks +0 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 1 month ago (2015-11-02 15:07:47 UTC) #2
sigurdm
Nice! LGTM
5 years, 1 month ago (2015-11-02 15:13:30 UTC) #3
Johnni Winther
5 years, 1 month ago (2015-11-03 08:41:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e2e899a53ff873c1d04ec433161a6470574e084a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698