Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: net/quic/test_tools/quic_test_utils.cc

Issue 1433433003: Rename MockHelper to the more descriptive (and more consistent with other Mock classes) MockConnect… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@106414015
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/quic_test_utils.h ('k') | net/tools/quic/quic_client_session_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/test_tools/quic_test_utils.cc
diff --git a/net/quic/test_tools/quic_test_utils.cc b/net/quic/test_tools/quic_test_utils.cc
index 2f59329ec8e22f1d85cdaa589884de9d2267270c..e01ff8cea52207a98aad58e1e11cc9fc7fa0e20f 100644
--- a/net/quic/test_tools/quic_test_utils.cc
+++ b/net/quic/test_tools/quic_test_utils.cc
@@ -33,7 +33,7 @@ namespace net {
namespace test {
namespace {
-// No-op alarm implementation used by MockHelper.
+// No-op alarm implementation used by MockConnectionHelper.
class TestAlarm : public QuicAlarm {
public:
explicit TestAlarm(QuicAlarm::Delegate* delegate)
@@ -204,23 +204,21 @@ MockConnectionVisitor::MockConnectionVisitor() {}
MockConnectionVisitor::~MockConnectionVisitor() {}
-MockHelper::MockHelper() {}
+MockConnectionHelper::MockConnectionHelper() {}
-MockHelper::~MockHelper() {}
+MockConnectionHelper::~MockConnectionHelper() {}
-const QuicClock* MockHelper::GetClock() const {
- return &clock_;
-}
+const QuicClock* MockConnectionHelper::GetClock() const { return &clock_; }
-QuicRandom* MockHelper::GetRandomGenerator() {
+QuicRandom* MockConnectionHelper::GetRandomGenerator() {
return &random_generator_;
}
-QuicAlarm* MockHelper::CreateAlarm(QuicAlarm::Delegate* delegate) {
+QuicAlarm* MockConnectionHelper::CreateAlarm(QuicAlarm::Delegate* delegate) {
return new TestAlarm(delegate);
}
-void MockHelper::AdvanceTime(QuicTime::Delta delta) {
+void MockConnectionHelper::AdvanceTime(QuicTime::Delta delta) {
clock_.AdvanceTime(delta);
}
@@ -229,7 +227,8 @@ QuicPacketWriter* NiceMockPacketWriterFactory::Create(
return new testing::NiceMock<MockPacketWriter>();
}
-MockConnection::MockConnection(MockHelper* helper, Perspective perspective)
+MockConnection::MockConnection(MockConnectionHelper* helper,
+ Perspective perspective)
: MockConnection(kTestConnectionId,
IPEndPoint(TestPeerIPAddress(), kTestPort),
helper,
@@ -237,7 +236,7 @@ MockConnection::MockConnection(MockHelper* helper, Perspective perspective)
QuicSupportedVersions()) {}
MockConnection::MockConnection(IPEndPoint address,
- MockHelper* helper,
+ MockConnectionHelper* helper,
Perspective perspective)
: MockConnection(kTestConnectionId,
address,
@@ -246,7 +245,7 @@ MockConnection::MockConnection(IPEndPoint address,
QuicSupportedVersions()) {}
MockConnection::MockConnection(QuicConnectionId connection_id,
- MockHelper* helper,
+ MockConnectionHelper* helper,
Perspective perspective)
: MockConnection(connection_id,
IPEndPoint(TestPeerIPAddress(), kTestPort),
@@ -254,7 +253,7 @@ MockConnection::MockConnection(QuicConnectionId connection_id,
perspective,
QuicSupportedVersions()) {}
-MockConnection::MockConnection(MockHelper* helper,
+MockConnection::MockConnection(MockConnectionHelper* helper,
Perspective perspective,
const QuicVersionVector& supported_versions)
: MockConnection(kTestConnectionId,
@@ -265,7 +264,7 @@ MockConnection::MockConnection(MockHelper* helper,
MockConnection::MockConnection(QuicConnectionId connection_id,
IPEndPoint address,
- MockHelper* helper,
+ MockConnectionHelper* helper,
Perspective perspective,
const QuicVersionVector& supported_versions)
: QuicConnection(connection_id,
@@ -283,15 +282,15 @@ MockConnection::MockConnection(QuicConnectionId connection_id,
MockConnection::~MockConnection() {}
void MockConnection::AdvanceTime(QuicTime::Delta delta) {
- static_cast<MockHelper*>(helper())->AdvanceTime(delta);
+ static_cast<MockConnectionHelper*>(helper())->AdvanceTime(delta);
}
-PacketSavingConnection::PacketSavingConnection(MockHelper* helper,
+PacketSavingConnection::PacketSavingConnection(MockConnectionHelper* helper,
Perspective perspective)
: MockConnection(helper, perspective) {}
PacketSavingConnection::PacketSavingConnection(
- MockHelper* helper,
+ MockConnectionHelper* helper,
Perspective perspective,
const QuicVersionVector& supported_versions)
: MockConnection(helper, perspective, supported_versions) {}
@@ -755,7 +754,7 @@ MockQuicConnectionDebugVisitor::~MockQuicConnectionDebugVisitor() {}
void CreateClientSessionForTest(QuicServerId server_id,
bool supports_stateless_rejects,
QuicTime::Delta connection_start_time,
- MockHelper* helper,
+ MockConnectionHelper* helper,
QuicCryptoClientConfig* crypto_client_config,
PacketSavingConnection** client_connection,
TestQuicSpdyClientSession** client_session) {
@@ -778,7 +777,7 @@ void CreateClientSessionForTest(QuicServerId server_id,
void CreateServerSessionForTest(QuicServerId server_id,
QuicTime::Delta connection_start_time,
- MockHelper* helper,
+ MockConnectionHelper* helper,
QuicCryptoServerConfig* server_crypto_config,
PacketSavingConnection** server_connection,
TestQuicSpdyServerSession** server_session) {
« no previous file with comments | « net/quic/test_tools/quic_test_utils.h ('k') | net/tools/quic/quic_client_session_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698