Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: net/quic/quic_crypto_server_stream_test.cc

Issue 1433433003: Rename MockHelper to the more descriptive (and more consistent with other Mock classes) MockConnect… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@106414015
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_crypto_client_stream_test.cc ('k') | net/quic/quic_crypto_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_crypto_server_stream_test.cc
diff --git a/net/quic/quic_crypto_server_stream_test.cc b/net/quic/quic_crypto_server_stream_test.cc
index af3bcb368d49995b8b09d1ba5f6637a20b5f09eb..0dd0b7f8ed2e8192d45f510fcd532a2547363060 100644
--- a/net/quic/quic_crypto_server_stream_test.cc
+++ b/net/quic/quic_crypto_server_stream_test.cc
@@ -99,7 +99,8 @@ class QuicCryptoServerStreamTest : public ::testing::TestWithParam<bool> {
// called multiple times.
void InitializeServer() {
TestQuicSpdyServerSession* server_session = nullptr;
- helpers_.push_back(new MockHelper);
+ helpers_.push_back(new MockConnectionHelper);
+
CreateServerSessionForTest(server_id_, QuicTime::Delta::FromSeconds(100000),
helpers_.back(), &server_crypto_config_,
&server_connection_, &server_session);
@@ -122,7 +123,7 @@ class QuicCryptoServerStreamTest : public ::testing::TestWithParam<bool> {
// testing. May be called multiple times.
void InitializeFakeClient(bool supports_stateless_rejects) {
TestQuicSpdyClientSession* client_session = nullptr;
- helpers_.push_back(new MockHelper);
+ helpers_.push_back(new MockConnectionHelper);
CreateClientSessionForTest(server_id_, supports_stateless_rejects,
QuicTime::Delta::FromSeconds(100000),
helpers_.back(), &client_crypto_config_,
@@ -164,9 +165,10 @@ class QuicCryptoServerStreamTest : public ::testing::TestWithParam<bool> {
}
protected:
- // Every connection gets its own MockHelper, tracked separately from the
- // server and client state so their lifetimes persist through the whole test.
- std::vector<MockHelper*> helpers_;
+ // Every connection gets its own MockConnectionHelper, tracked separately
+ // from the server and client state so their lifetimes persist through the
+ // whole test.
+ std::vector<MockConnectionHelper*> helpers_;
// Server state
PacketSavingConnection* server_connection_;
« no previous file with comments | « net/quic/quic_crypto_client_stream_test.cc ('k') | net/quic/quic_crypto_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698