Add Box object to heap profiler.

Add Box object to heap profiler.

LOG=Y
R=ulan@chromium.org, yurys@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=19063

[alph, 2014-01-29 12:56:20]

ptal

[yurys, 2014-01-29 12:57:36]

Please add a test for this.

[alph, 2014-01-29 13:18:38]

On 2014/01/29 12:57:36, yurys wrote:
> Please add a test for this.

Do you know how to obtain one?

[alph, 2014-01-30 12:14:29]

On 2014/01/29 13:18:38, alph wrote:
> On 2014/01/29 12:57:36, yurys wrote:
> > Please add a test for this.
> 
> Do you know how to obtain one?

Looks like I managed to extract one. ;-) ptal

[yurys, 2014-01-30 13:34:34]

https://codereview.chromium.org/143343006/diff/30001/test/cctest/test-heap-pr...
File test/cctest/test-heap-profiler.cc (right):

https://codereview.chromium.org/143343006/diff/30001/test/cctest/test-heap-pr...
test/cctest/test-heap-profiler.cc:2387: if (strcmp(*type_node_name, "system /
Box") != 0)
This looks a bit fragile, would it be enough to set a number from native code
and then check that it is boxed?

[alph, 2014-02-03 09:21:55]

ptal

[yurys, 2014-02-03 09:26:26]

lgtm

https://codereview.chromium.org/143343006/diff/70001/test/cctest/test-heap-pr...
File test/cctest/test-heap-profiler.cc (right):

https://codereview.chromium.org/143343006/diff/70001/test/cctest/test-heap-pr...
test/cctest/test-heap-profiler.cc:2397: CHECK_EQ(1,
global->InternalFieldCount());
Do you really need this check in this test?

[alph, 2014-02-04 09:41:54]

https://codereview.chromium.org/143343006/diff/70001/test/cctest/test-heap-pr...
File test/cctest/test-heap-profiler.cc (right):

https://codereview.chromium.org/143343006/diff/70001/test/cctest/test-heap-pr...
test/cctest/test-heap-profiler.cc:2397: CHECK_EQ(1,
global->InternalFieldCount());
On 2014/02/03 09:26:27, yurys wrote:
> Do you really need this check in this test?

Done.

[ulan, 2014-02-04 09:42:00]

lgtm

[alph, 2014-02-04 11:43:30]

Committed patchset #5 manually as r19063 (presubmit successful).