Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: core/src/fpdfapi/fpdf_render/fpdf_render_loadimage_embeddertest.cpp

Issue 1433423002: Fix extraction of colour components in CPDF_DIBSource::DownSampleScanline32Bit (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: delete unwanted change Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/src/fpdfapi/fpdf_render/fpdf_render_loadimage_embeddertest.cpp
diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_func_embeddertest.cpp b/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage_embeddertest.cpp
similarity index 55%
copy from core/src/fpdfapi/fpdf_page/fpdf_page_func_embeddertest.cpp
copy to core/src/fpdfapi/fpdf_render/fpdf_render_loadimage_embeddertest.cpp
index 28920368825b627f779c3905e6bf2a37731b9a2d..1633249d0d33e09ddbbf923e7a8015f39f347788 100644
--- a/core/src/fpdfapi/fpdf_page/fpdf_page_func_embeddertest.cpp
+++ b/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage_embeddertest.cpp
@@ -5,13 +5,12 @@
#include "testing/embedder_test.h"
#include "testing/gtest/include/gtest/gtest.h"
-class FPDFPageFuncEmbeddertest : public EmbedderTest {};
+class FPDFRenderLoadImageEmbeddertest : public EmbedderTest {};
-TEST_F(FPDFPageFuncEmbeddertest, Bug_551460) {
- // Should not crash under ASan.
- // Tests that the number of inputs is not simply calculated from the domain
- // and trusted. The number of inputs has to be 1.
- EXPECT_TRUE(OpenDocument("bug_551460.pdf"));
+TEST_F(FPDFRenderLoadImageEmbeddertest, Bug_554151) {
+ // Test scanline downsampling with a BitsPerComponent of 4.
+ // Should not crash.
+ EXPECT_TRUE(OpenDocument("bug_554151.pdf"));
FPDF_PAGE page = LoadPage(0);
EXPECT_NE(nullptr, page);
FPDF_BITMAP bitmap = RenderPage(page);

Powered by Google App Engine
This is Rietveld 408576698