Chromium Code Reviews Chromium Code Reviews
Issue 14334014:
Parse "-webkit-columns: auto <length>" properly. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/multicol/columns-shorthand-parsing-2.html |
| diff --git a/LayoutTests/fast/multicol/columns-shorthand-parsing-2.html b/LayoutTests/fast/multicol/columns-shorthand-parsing-2.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..f7271a1cedf8f02aa8ca9a1850878efd7d01bcaf |
| --- /dev/null |
| +++ b/LayoutTests/fast/multicol/columns-shorthand-parsing-2.html |
| @@ -0,0 +1,39 @@ |
| +<!DOCTYPE html> |
| +<html> |
| + <head> |
| + <title>'columns' property with 'auto' and something else</title> |
| + <script src="../js/resources/js-test-pre.js"></script> |
| + <script> |
| + description("Test the behavior when 'auto' is part of the 'columns' property value. See http://www.w3.org/TR/css3-multicol/#columns"); |
| + if (window.testRunner) |
| + testRunner.dumpAsText(); |
| + |
| + function runTests() { |
| + var tests = [["-webkit-columns:auto 3;", "3", "auto"], |
| + ["-webkit-columns:auto 10em;", "auto", "10em"], |
|
Julien - ping for review
2013/07/23 17:26:50
Nit: You could remove the -webkit-columns in all t
mstensho (USE GERRIT)
2013/07/23 21:35:33
Yes, that would avoid some repetition, but wouldn'
|
| + ["-webkit-columns:3 auto;", "3", "auto"], |
| + ["-webkit-columns:10em auto;", "auto", "10em"], |
| + ["-webkit-columns:7 7em; -webkit-columns:auto auto auto;", "7", "7em"], |
| + ["-webkit-columns:7 7em; -webkit-columns:10em auto auto;", "7", "7em"], |
| + ["-webkit-columns:7 7em; -webkit-columns:auto;", "auto", "auto"], |
| + ["-webkit-columns:7 7em; -webkit-columns:auto auto;", "auto", "auto"], |
| + ["-webkit-columns:auto; -webkit-columns:initial;", "initial", "initial"], |
| + ["-webkit-columns:auto; -webkit-columns:initial initial;", "auto", "auto"], |
| + ["-webkit-columns:auto; -webkit-columns:inherit;", "inherit", "inherit"], |
| + ["-webkit-columns:auto; -webkit-columns:inherit inherit;", "auto", "auto"], |
| + ["-webkit-columns:7;", "7", "initial"], |
| + ["-webkit-columns:7em;", "initial", "7em"]]; |
| + |
| + tests.forEach(function(test) { |
| + elm.style.cssText = test[0]; |
|
Julien - ping for review
2013/07/23 17:26:50
Let's avoid shortening the variable names, especia
mstensho (USE GERRIT)
2013/07/23 21:35:33
Done.
|
| + shouldBeEqualToString("elm.style.WebkitColumnCount", test[1]); |
| + shouldBeEqualToString("elm.style.WebkitColumnWidth", test[2]); |
| + }); |
| + } |
| + </script> |
| + </head> |
| + <body onload="runTests()"> |
| + <div id="elm"></div> |
| + <script src="../js/resources/js-test-post.js"></script> |
| + </body> |
| +</html> |
