Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: Source/core/css/StylePropertyShorthand.h

Issue 14334014: Parse "-webkit-columns: auto <length>" properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/StylePropertyShorthand.h
diff --git a/Source/core/css/StylePropertyShorthand.h b/Source/core/css/StylePropertyShorthand.h
index e421f179d26856d10766015a58d489004fae2ddb..13a7691dbb066f9c56a452e233e131fc426689fd 100644
--- a/Source/core/css/StylePropertyShorthand.h
+++ b/Source/core/css/StylePropertyShorthand.h
@@ -32,31 +32,36 @@ public:
: m_properties(0)
, m_propertiesForInitialization(0)
, m_length(0)
+ , m_allAcceptAuto(false)
{
}
- StylePropertyShorthand(const CSSPropertyID* properties, unsigned numProperties)
+ StylePropertyShorthand(const CSSPropertyID* properties, unsigned numProperties, bool allAcceptAuto = false)
Julien - ping for review 2013/07/23 00:56:29 NO! This class represents a generic shorthand, no
mstensho (USE GERRIT) 2013/07/23 14:19:07 Done. Also, my patch doesn't even apply anymore,
: m_properties(properties)
, m_propertiesForInitialization(0)
, m_length(numProperties)
+ , m_allAcceptAuto(allAcceptAuto)
{
}
- StylePropertyShorthand(const CSSPropertyID* properties, const StylePropertyShorthand** propertiesForInitialization, unsigned numProperties)
+ StylePropertyShorthand(const CSSPropertyID* properties, const StylePropertyShorthand** propertiesForInitialization, unsigned numProperties, bool allAcceptAuto = false)
: m_properties(properties)
, m_propertiesForInitialization(propertiesForInitialization)
, m_length(numProperties)
+ , m_allAcceptAuto(allAcceptAuto)
{
}
const CSSPropertyID* properties() const { return m_properties; }
const StylePropertyShorthand** propertiesForInitialization() const { return m_propertiesForInitialization; }
unsigned length() const { return m_length; }
+ bool allAcceptAuto() const { return m_allAcceptAuto; }
private:
const CSSPropertyID* m_properties;
const StylePropertyShorthand** m_propertiesForInitialization;
unsigned m_length;
+ bool m_allAcceptAuto;
};
const StylePropertyShorthand& backgroundShorthand();

Powered by Google App Engine
This is Rietveld 408576698