LayoutTests/fast/multicol/columns-shorthand-parsing-2.html - Issue 14334014: Parse "-webkit-columns: auto <length>" properly.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/columns-shorthand-parsing-2.html

Issue 14334014: Parse "-webkit-columns: auto <length>" properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review #3 Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>'columns' property with 'auto' and something else</title>

	5 <script src="../js/resources/js-test-pre.js"></script>

	6 <script>

	7 description("Test the behavior when 'auto' is part of the 'columns' proper ty value. See http://www.w3.org/TR/css3-multicol/#columns");

	8 if (window.testRunner)

	9 testRunner.dumpAsText();

	10

	11 function runTests() {

	12 var tests = [["-webkit-columns:auto 3;", "auto", "3", "auto 3"],

	13 ["-webkit-columns:auto 10em;", "10em", "auto", "10em auto "],

	14 ["-webkit-columns:3 auto;", "auto", "3", "auto 3"],

	15 ["-webkit-columns:10em auto;", "10em", "auto", "10em auto "],

	16 ["-webkit-columns:7 7em; -webkit-columns:auto auto auto;" , "7em", "7", "7em 7"],

	17 ["-webkit-columns:7 7em; -webkit-columns:10em auto auto;" , "7em", "7", "7em 7"],

	18 ["-webkit-columns:7 7em; -webkit-columns:auto;", "auto", "auto", "auto"],

	19 ["-webkit-columns:7 7em; -webkit-columns:auto auto;", "a uto", "auto", "auto auto"],

	20 ["-webkit-columns:auto; -webkit-columns:initial;", "initi al", "initial", "initial"],

	21 ["-webkit-columns:auto; -webkit-columns:initial initial;" , "auto", "auto", "auto"],

	22 ["-webkit-columns:auto; -webkit-columns:inherit;", "inher it", "inherit", "inherit"],

	23 ["-webkit-columns:auto; -webkit-columns:inherit inherit;" , "auto", "auto", "auto"],

	24 ["-webkit-columns:7;", "auto", "7", "7"],

	25 ["-webkit-columns:7em;", "7em", "auto", "7em"]];

	26

	27 tests.forEach(function(test) {

	28 element.style.cssText = test[0];

	29 shouldBeEqualToString("element.style.WebkitColumnWidth", test[1]);

	30 shouldBeEqualToString("element.style.WebkitColumnCount", test[2]);

	31 shouldBeEqualToString("element.style.WebkitColumns", test[3]);

	32 });

	33 }

	34 </script>

	35 </head>

	36 <body onload="runTests()">
	Julien - ping for review 2013/07/26 20:14:39 Because you use the onload event to run the test, Because you use the onload event to run the test, the output is out of order (the "PASS successfullyParsed is true" is before the test above). Several ways to solve that: - don't use the onload event and move the inline script just after #element so that it's accessible inline. - don't include js-test-post.js but set \|successfullyParsed\| to true and call finishJSTest() at the end of your test. The first solution is definitely better though :) mstensho (USE GERRIT) 2013/07/26 22:20:19 Done. Show quoted text On 2013/07/26 20:14:39, Julien Chaffraix wrote: > Because you use the onload event to run the test, the output is out of order > (the "PASS successfullyParsed is true" is before the test above). Several ways > to solve that: > - don't use the onload event and move the inline script just after #element so > that it's accessible inline. > - don't include js-test-post.js but set \|successfullyParsed\| to true and call > finishJSTest() at the end of your test. > > The first solution is definitely better though :) Done.
	37 <div id="element"></div>

	38 <script src="../js/resources/js-test-post.js"></script>

	39 </body>

	40 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/multicol/columns-shorthand-parsing-2-expected.txt » ('j') | Source/core/css/CSSParser-in.cpp » ('J')