LayoutTests/fast/multicol/columns-shorthand-parsing-2.html - Issue 14334014: Parse "-webkit-columns: auto <length>" properly.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/columns-shorthand-parsing-2.html

Issue 14334014: Parse "-webkit-columns: auto <length>" properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase master + minor coding style fix that the old version of check-webkit-style didn't complain a… Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>'columns' property with 'auto' and something else</title>

	5 <script src="../js/resources/js-test-pre.js"></script>

	6 <script>

	7 description("Test the behavior when 'auto' is part of the 'columns' proper ty value. See http://www.w3.org/TR/css3-multicol/#columns");

	8 if (window.testRunner)

	9 testRunner.dumpAsText();

	10

	11 function runTests() {

	12 var tests = [["-webkit-columns:auto 3;", "3", "auto"],

	13 ["-webkit-columns:auto 10em;", "auto", "10em"],
	Julien - ping for review 2013/07/23 17:26:50 Nit: You could remove the -webkit-columns in all t Nit: You could remove the -webkit-columns in all these entries by changing your test function to: elm.style.cssText = "-webkit-column: " + test[0]; mstensho (USE GERRIT) 2013/07/23 21:35:33 Yes, that would avoid some repetition, but wouldn' Show quoted text On 2013/07/23 17:26:50, Julien Chaffraix wrote: > Nit: You could remove the -webkit-columns in all these entries by changing your > test function to: > > elm.style.cssText = "-webkit-column: " + test[0]; Yes, that would avoid some repetition, but wouldn't it just look weird in the cases where I actually have double declarations? "7 7em; -webkit-columns:auto auto auto;"
	14 ["-webkit-columns:3 auto;", "3", "auto"],

	15 ["-webkit-columns:10em auto;", "auto", "10em"],

	16 ["-webkit-columns:7 7em; -webkit-columns:auto auto auto;" , "7", "7em"],

	17 ["-webkit-columns:7 7em; -webkit-columns:10em auto auto;" , "7", "7em"],

	18 ["-webkit-columns:7 7em; -webkit-columns:auto;", "auto", "auto"],

	19 ["-webkit-columns:7 7em; -webkit-columns:auto auto;", "a uto", "auto"],

	20 ["-webkit-columns:auto; -webkit-columns:initial;", "initi al", "initial"],

	21 ["-webkit-columns:auto; -webkit-columns:initial initial;" , "auto", "auto"],

	22 ["-webkit-columns:auto; -webkit-columns:inherit;", "inher it", "inherit"],

	23 ["-webkit-columns:auto; -webkit-columns:inherit inherit;" , "auto", "auto"],

	24 ["-webkit-columns:7;", "7", "initial"],

	25 ["-webkit-columns:7em;", "initial", "7em"]];

	26

	27 tests.forEach(function(test) {

	28 elm.style.cssText = test[0];
	Julien - ping for review 2013/07/23 17:26:50 Let's avoid shortening the variable names, especia Let's avoid shortening the variable names, especially since it doesn't save much (apart from readability). mstensho (USE GERRIT) 2013/07/23 21:35:33 Done. Show quoted text On 2013/07/23 17:26:50, Julien Chaffraix wrote: > Let's avoid shortening the variable names, especially since it doesn't save much > (apart from readability). Done.
	29 shouldBeEqualToString("elm.style.WebkitColumnCount", test[1]);

	30 shouldBeEqualToString("elm.style.WebkitColumnWidth", test[2]);

	31 });

	32 }

	33 </script>

	34 </head>

	35 <body onload="runTests()">

	36 <div id="elm"></div>

	37 <script src="../js/resources/js-test-post.js"></script>

	38 </body>

	39 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/multicol/columns-shorthand-parsing-2-expected.txt » ('j') | Source/core/css/CSSParser-in.cpp » ('J')