Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Side by Side Diff: Source/core/css/StylePropertyShorthand.cpp

Issue 14334014: Parse "-webkit-columns: auto <length>" properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 const StylePropertyShorthand& webkitBorderStartShorthand() 322 const StylePropertyShorthand& webkitBorderStartShorthand()
323 { 323 {
324 static const CSSPropertyID borderStartProperties[] = { CSSPropertyWebkitBord erStartWidth, CSSPropertyWebkitBorderStartStyle, CSSPropertyWebkitBorderStartCol or }; 324 static const CSSPropertyID borderStartProperties[] = { CSSPropertyWebkitBord erStartWidth, CSSPropertyWebkitBorderStartStyle, CSSPropertyWebkitBorderStartCol or };
325 DEFINE_STATIC_LOCAL(StylePropertyShorthand, webkitBorderStartLonghands, (bor derStartProperties, WTF_ARRAY_LENGTH(borderStartProperties))); 325 DEFINE_STATIC_LOCAL(StylePropertyShorthand, webkitBorderStartLonghands, (bor derStartProperties, WTF_ARRAY_LENGTH(borderStartProperties)));
326 return webkitBorderStartLonghands; 326 return webkitBorderStartLonghands;
327 } 327 }
328 328
329 const StylePropertyShorthand& webkitColumnsShorthand() 329 const StylePropertyShorthand& webkitColumnsShorthand()
330 { 330 {
331 static const CSSPropertyID columnsProperties[] = { CSSPropertyWebkitColumnWi dth, CSSPropertyWebkitColumnCount }; 331 static const CSSPropertyID columnsProperties[] = { CSSPropertyWebkitColumnWi dth, CSSPropertyWebkitColumnCount };
332 DEFINE_STATIC_LOCAL(StylePropertyShorthand, webkitColumnsLonghands, (columns Properties, WTF_ARRAY_LENGTH(columnsProperties))); 332 DEFINE_STATIC_LOCAL(StylePropertyShorthand, webkitColumnsLonghands, (columns Properties, WTF_ARRAY_LENGTH(columnsProperties), true));
333 return webkitColumnsLonghands; 333 return webkitColumnsLonghands;
334 } 334 }
335 335
336 const StylePropertyShorthand& webkitColumnRuleShorthand() 336 const StylePropertyShorthand& webkitColumnRuleShorthand()
337 { 337 {
338 static const CSSPropertyID columnRuleProperties[] = { 338 static const CSSPropertyID columnRuleProperties[] = {
339 CSSPropertyWebkitColumnRuleWidth, 339 CSSPropertyWebkitColumnRuleWidth,
340 CSSPropertyWebkitColumnRuleStyle, 340 CSSPropertyWebkitColumnRuleStyle,
341 CSSPropertyWebkitColumnRuleColor, 341 CSSPropertyWebkitColumnRuleColor,
342 }; 342 };
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
588 // thus we need to special case it here. FIXME: This is a violation of CSS 3 Fonts 588 // thus we need to special case it here. FIXME: This is a violation of CSS 3 Fonts
589 // as we should still be able to change the longhands. 589 // as we should still be able to change the longhands.
590 // DON'T ADD ANY SHORTHAND HERE UNLESS IT ISN'T ALWAYS EXPANDED AT PARSE TIM E (which is wrong). 590 // DON'T ADD ANY SHORTHAND HERE UNLESS IT ISN'T ALWAYS EXPANDED AT PARSE TIM E (which is wrong).
591 if (id == CSSPropertyFont) 591 if (id == CSSPropertyFont)
592 return false; 592 return false;
593 593
594 return shorthandForProperty(id).length(); 594 return shorthandForProperty(id).length();
595 } 595 }
596 596
597 } // namespace WebCore 597 } // namespace WebCore
OLDNEW
« Source/core/css/StylePropertyShorthand.h ('K') | « Source/core/css/StylePropertyShorthand.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698