LayoutTests/fast/multicol/columns-shorthand-parsing-2.html - Issue 14334014: Parse "-webkit-columns: auto <length>" properly.

Side by Side Diff: LayoutTests/fast/multicol/columns-shorthand-parsing-2.html

Issue 14334014: Parse "-webkit-columns: auto <length>" properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>'columns' property with 'auto' and something else</title>

	5 <script src="../js/resources/js-test-pre.js"></script>

	6 <script>

	7 description("Test the behavior when 'auto' is part of the 'columns' proper ty value. See http://www.w3.org/TR/css3-multicol/#columns");

	8 if (window.testRunner)

	9 testRunner.dumpAsText();

	10 </script>

	11 </head>

	12 <body>

	13 <div id="elm1" style="-webkit-columns:auto 3;"></div>

	14 <div id="elm2" style="-webkit-columns:auto 10em;"></div>

	15 <div id="elm3" style="-webkit-columns:3 auto;"></div>

	16 <div id="elm4" style="-webkit-columns:10em auto;"></div>

	17 <div id="elm5" style="-webkit-columns:7 7em; -webkit-columns:auto auto auto; "></div>

	18 <div id="elm6" style="-webkit-columns:7 7em; -webkit-columns:10em auto auto; "></div>

	19 <div id="elm7" style="-webkit-columns:7 7em; -webkit-columns:auto;"></div>

	20 <div id="elm8" style="-webkit-columns:7 7em; -webkit-columns:auto auto;"></d iv>

	21 <div id="elm9" style="-webkit-columns:auto; -webkit-columns:initial;"></div>

	22 <div id="elm10" style="-webkit-columns:auto; -webkit-columns:initial initial ;"></div>

	23 <div id="elm11" style="-webkit-columns:auto; -webkit-columns:inherit;"></div >

	24 <div id="elm12" style="-webkit-columns:auto; -webkit-columns:inherit inherit ;"></div>

	25 <div id="elm13" style="-webkit-columns:7;"></div>

	26 <div id="elm14" style="-webkit-columns:7em;"></div>

	27 <script>

	28 shouldBeEqualToString("document.getElementById('elm1').style.WebkitColumnW idth", "auto");
	Julien - ping for review 2013/07/23 00:56:29 It would be more readable to move the repeated tes It would be more readable to move the repeated testing code to its own function. Maybe it would be better to do the setting in JavaScript using Element.style (not really sure about this one)? Nit: I usually prefer to test using window.getComputedStyle as Element.style returns nonsensical values sometimes (like I would have expected 'initial' and 'inherit' to be computed below but no). Not sure how well this would work though. mstensho (USE GERRIT) 2013/07/23 14:19:07 Done. I think I want to keep using Element.style; Show quoted text On 2013/07/23 00:56:29, Julien Chaffraix wrote: > It would be more readable to move the repeated testing code to its own function. > Maybe it would be better to do the setting in JavaScript using Element.style > (not really sure about this one)? > > Nit: I usually prefer to test using window.getComputedStyle as Element.style > returns nonsensical values sometimes (like I would have expected 'initial' and > 'inherit' to be computed below but no). Not sure how well this would work > though. Done. I think I want to keep using Element.style; that gives me the _specified_ property values (as long as they're part of the style attribute, of course). I don't want to look at the _computed_ values, since that's further from what the parser produces.
	29 shouldBeEqualToString("document.getElementById('elm1').style.WebkitColumnC ount", "3");

	30 shouldBeEqualToString("document.getElementById('elm2').style.WebkitColumnW idth", "10em");

	31 shouldBeEqualToString("document.getElementById('elm2').style.WebkitColumnC ount", "auto");

	32 shouldBeEqualToString("document.getElementById('elm3').style.WebkitColumnW idth", "auto");

	33 shouldBeEqualToString("document.getElementById('elm3').style.WebkitColumnC ount", "3");

	34 shouldBeEqualToString("document.getElementById('elm4').style.WebkitColumnW idth", "10em");

	35 shouldBeEqualToString("document.getElementById('elm4').style.WebkitColumnC ount", "auto");

	36 shouldBeEqualToString("document.getElementById('elm5').style.WebkitColumnW idth", "7em");

	37 shouldBeEqualToString("document.getElementById('elm5').style.WebkitColumnC ount", "7");

	38 shouldBeEqualToString("document.getElementById('elm6').style.WebkitColumnW idth", "7em");

	39 shouldBeEqualToString("document.getElementById('elm6').style.WebkitColumnC ount", "7");

	40 shouldBeEqualToString("document.getElementById('elm7').style.WebkitColumnW idth", "auto");

	41 shouldBeEqualToString("document.getElementById('elm7').style.WebkitColumnC ount", "auto");

	42 shouldBeEqualToString("document.getElementById('elm8').style.WebkitColumnW idth", "auto");

	43 shouldBeEqualToString("document.getElementById('elm8').style.WebkitColumnC ount", "auto");

	44 shouldBeEqualToString("document.getElementById('elm9').style.WebkitColumnC ount", "initial");

	45 shouldBeEqualToString("document.getElementById('elm9').style.WebkitColumnW idth", "initial");

	46 shouldBeEqualToString("document.getElementById('elm10').style.WebkitColumn Count", "auto");

	47 shouldBeEqualToString("document.getElementById('elm10').style.WebkitColumn Width", "auto");

	48 shouldBeEqualToString("document.getElementById('elm11').style.WebkitColumn Count", "inherit");

	49 shouldBeEqualToString("document.getElementById('elm11').style.WebkitColumn Width", "inherit");

	50 shouldBeEqualToString("document.getElementById('elm12').style.WebkitColumn Count", "auto");

	51 shouldBeEqualToString("document.getElementById('elm12').style.WebkitColumn Width", "auto");

	52 shouldBeEqualToString("document.getElementById('elm13').style.WebkitColumn Count", "7");

	53 shouldBeEqualToString("document.getElementById('elm13').style.WebkitColumn Width", "initial");

	54 shouldBeEqualToString("document.getElementById('elm14').style.WebkitColumn Count", "initial");

	55 shouldBeEqualToString("document.getElementById('elm14').style.WebkitColumn Width", "7em");

	56 </script>

	57 <script src="../js/resources/js-test-post.js"></script>

	58 </body>

	59 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/multicol/columns-shorthand-parsing-2-expected.txt » ('j') | Source/core/css/CSSParser.cpp » ('J')