Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 14334002: Delete WorldContextHandle in favor of DOMWrapperWorld (Closed)

Created:
7 years, 8 months ago by adamk
Modified:
7 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jsbell, alecflett, dgrogan, Nate Chapin
Visibility:
Public.

Description

Delete WorldContextHandle in favor of DOMWrapperWorld This updates the last callers of WorldContextHandle: EventListeners. It also changes DOMWrapperWorld::current() to determine whether it's operating in a worker or a document context using WrapperTypeInfo on the v8::Context instead of taking a ScriptExecutionContext (since some callers don't have one available). R=abarth BUG=230460 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148670

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -188 lines) Patch
M Source/WebKit/chromium/tests/IDBBindingUtilitiesTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/bindings.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/scripts/CodeGeneratorV8.pm View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/DOMRequestState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/DOMWrapperWorld.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/DOMWrapperWorld.cpp View 1 chunk +7 lines, -5 lines 1 comment Download
M Source/bindings/v8/ScriptEventListener.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/V8AbstractEventListener.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/V8AbstractEventListener.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8Binding.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M Source/bindings/v8/V8EventListener.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/V8EventListener.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8LazyEventListener.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8MutationCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8WindowErrorHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8WorkerContextErrorHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8WorkerContextEventListener.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/bindings/v8/WorldContextHandle.h View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/bindings/v8/WorldContextHandle.cpp View 1 chunk +0 lines, -82 lines 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
adamk
7 years, 8 months ago (2013-04-18 01:55:10 UTC) #1
haraken
Looks great to me, but abarth should look.
7 years, 8 months ago (2013-04-18 02:11:52 UTC) #2
abarth-chromium
LGTM!!! https://codereview.chromium.org/14334002/diff/1/Source/bindings/v8/DOMWrapperWorld.cpp File Source/bindings/v8/DOMWrapperWorld.cpp (right): https://codereview.chromium.org/14334002/diff/1/Source/bindings/v8/DOMWrapperWorld.cpp#newcode72 Source/bindings/v8/DOMWrapperWorld.cpp:72: if (!V8DOMWrapper::isWrapperOfType(toInnerGlobalObject(context), &V8DOMWindow::info)) toInnerGlobalObject can be slow, but ...
7 years, 8 months ago (2013-04-18 05:41:51 UTC) #3
adamk
On 2013/04/18 05:41:51, abarth wrote: > LGTM!!! > > https://codereview.chromium.org/14334002/diff/1/Source/bindings/v8/DOMWrapperWorld.cpp > File Source/bindings/v8/DOMWrapperWorld.cpp (right): > ...
7 years, 8 months ago (2013-04-18 16:09:24 UTC) #4
abarth-chromium
On 2013/04/18 16:09:24, adamk wrote: > How slow? Roughly the cost of a hash-table lookup.
7 years, 8 months ago (2013-04-18 16:12:26 UTC) #5
adamk
On 2013/04/18 16:12:26, abarth wrote: > On 2013/04/18 16:09:24, adamk wrote: > > How slow? ...
7 years, 8 months ago (2013-04-18 17:05:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/14334002/1
7 years, 8 months ago (2013-04-18 17:05:20 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 17:36:11 UTC) #8
Message was sent while issue was closed.
Change committed as 148670

Powered by Google App Engine
This is Rietveld 408576698