Use SequenceChecker to allow Timer to run in SequencedWorkerPool

base/timer/timer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/timer/timer.h"
 
 #include <stddef.h>
 
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
-#include "base/single_thread_task_runner.h"
-#include "base/thread_task_runner_handle.h"
-#include "base/threading/platform_thread.h"
+#include "base/threading/sequenced_task_runner_handle.h"
 
 namespace base {
 
 // BaseTimerTaskInternal is a simple delegate for scheduling a callback to
-// Timer in the thread's default task runner. It also handles the following
-// edge cases:
+// Timer in the task runner. It also handles the following edge cases:
 // - deleted by the task runner.
 // - abandoned (orphaned) by Timer.
 class BaseTimerTaskInternal {
  public:
   explicit BaseTimerTaskInternal(Timer* timer)
       : timer_(timer) {
   }
 
   ~BaseTimerTaskInternal() {
     // This task may be getting cleared because the task runner has been
@@ skipping 24 matching lines @@
   void Abandon() {
     timer_ = NULL;
   }
 
  private:
   Timer* timer_;
 };
 
 Timer::Timer(bool retain_user_task, bool is_repeating)
     : scheduled_task_(NULL),
-      thread_id_(0),
+      was_scheduled_(false),
       is_repeating_(is_repeating),
       retain_user_task_(retain_user_task),
       is_running_(false) {
+  // It is safe for the timer to be created on a different thread (or
+  // sequenced task runner) from the one on which tasks are scheduled. The
+  // first call to the checker's CalledOnValidSequencedThread() method will
+  // re-bind the checker, and later calls will verify that the same task
+  // runner is used.
+  sequence_checker_.DetachFromSequence();
 }
 
 Timer::Timer(const tracked_objects::Location& posted_from,
              TimeDelta delay,
              const base::Closure& user_task,
              bool is_repeating)
     : scheduled_task_(NULL),
       posted_from_(posted_from),
       delay_(delay),
       user_task_(user_task),
-      thread_id_(0),
+      was_scheduled_(false),
       is_repeating_(is_repeating),
       retain_user_task_(true),
       is_running_(false) {
+  // See comment in other constructor.
+  sequence_checker_.DetachFromSequence();
 }
 
 Timer::~Timer() {
   StopAndAbandon();
 }
 
 bool Timer::IsRunning() const {
   return is_running_;
 }
 
 TimeDelta Timer::GetCurrentDelay() const {
   return delay_;
 }
 
-void Timer::SetTaskRunner(scoped_refptr<SingleThreadTaskRunner> task_runner) {
+void Timer::SetTaskRunner(scoped_refptr<SequencedTaskRunner> task_runner) {
   // Do not allow changing the task runner once something has been scheduled.
-  DCHECK_EQ(thread_id_, 0);
+  DCHECK_EQ(was_scheduled_, false);

[danakj, 2015/11/16 22:46:42]

DCHECK(!was_scheduled_) for a boolean

[jsbell, 2015/12/01 00:23:10]

Done.

   task_runner_.swap(task_runner);
 }
 
 void Timer::Start(const tracked_objects::Location& posted_from,
                   TimeDelta delay,
                   const base::Closure& user_task) {
   SetTaskInfo(posted_from, delay, user_task);
   Reset();
 }
 
@@ skipping 33 matching lines @@
 void Timer::SetTaskInfo(const tracked_objects::Location& posted_from,
                         TimeDelta delay,
                         const base::Closure& user_task) {
   posted_from_ = posted_from;
   delay_ = delay;
   user_task_ = user_task;
 }
 
 void Timer::PostNewScheduledTask(TimeDelta delay) {
   DCHECK(scheduled_task_ == NULL);
+  DCHECK(sequence_checker_.CalledOnValidSequencedThread());
+  was_scheduled_ = true;
   is_running_ = true;
   scheduled_task_ = new BaseTimerTaskInternal(this);
   if (delay > TimeDelta::FromMicroseconds(0)) {
     GetTaskRunner()->PostDelayedTask(posted_from_,
         base::Bind(&BaseTimerTaskInternal::Run, base::Owned(scheduled_task_)),
         delay);
     scheduled_run_time_ = desired_run_time_ = TimeTicks::Now() + delay;
   } else {
     GetTaskRunner()->PostTask(posted_from_,
         base::Bind(&BaseTimerTaskInternal::Run, base::Owned(scheduled_task_)));
     scheduled_run_time_ = desired_run_time_ = TimeTicks();
   }
-  // Remember the thread ID that posts the first task -- this will be verified
-  // later when the task is abandoned to detect misuse from multiple threads.
-  if (!thread_id_) {
-    DCHECK(GetTaskRunner()->BelongsToCurrentThread());
-    thread_id_ = static_cast<int>(PlatformThread::CurrentId());
-  }
 }
 
-scoped_refptr<SingleThreadTaskRunner> Timer::GetTaskRunner() {
-  return task_runner_.get() ? task_runner_ : ThreadTaskRunnerHandle::Get();
+scoped_refptr<SequencedTaskRunner> Timer::GetTaskRunner() {
+  return task_runner_.get() ? task_runner_ : SequencedTaskRunnerHandle::Get();
 }
 
 void Timer::AbandonScheduledTask() {
-  DCHECK(thread_id_ == 0 ||
-         thread_id_ == static_cast<int>(PlatformThread::CurrentId()));
+  DCHECK(sequence_checker_.CalledOnValidSequencedThread());
   if (scheduled_task_) {
     scheduled_task_->Abandon();
     scheduled_task_ = NULL;
   }
 }
 
 void Timer::RunScheduledTask() {
   // Task may have been disabled.
   if (!is_running_)
     return;
@@ skipping 20 matching lines @@
     PostNewScheduledTask(delay_);
   else
     Stop();
 
   task.Run();
 
   // No more member accesses here: *this could be deleted at this point.
 }
 
 }  // namespace base