Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 143333008: [Android] Remove the "Always show" button for blocked popups if the setting is controlled by policy. (Closed)

Created:
6 years, 10 months ago by Bernhard Bauer
Modified:
6 years, 10 months ago
Reviewers:
Yaron
CC:
chromium-reviews, Joao da Silva, gone, David Trainor- moved to gerrit
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue340704a
Visibility:
Public.

Description

[Android] Remove the "Always show" button for blocked popups if the setting is controlled by policy. BUG=342136, 340704 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250184

Patch Set 1 #

Patch Set 2 : x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -18 lines) Patch
M chrome/browser/android/tab_android.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.h View 2 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc View 1 5 chunks +31 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Bernhard Bauer
Please review. Thanks!
6 years, 10 months ago (2014-02-08 13:26:21 UTC) #1
Yaron
lgtm +dfalcantara,dtrainor as fyi
6 years, 10 months ago (2014-02-08 18:24:00 UTC) #2
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 10 months ago (2014-02-08 22:50:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/143333008/70001
6 years, 10 months ago (2014-02-08 22:50:31 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-08 23:25:01 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=223935
6 years, 10 months ago (2014-02-08 23:25:02 UTC) #6
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 10 months ago (2014-02-10 09:37:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/143333008/70001
6 years, 10 months ago (2014-02-10 09:37:27 UTC) #8
Jói
The CQ bit was unchecked by joi@chromium.org
6 years, 10 months ago (2014-02-10 11:47:17 UTC) #9
Jói
See my recent email to chromium-dev@ for why I unchecked the CQ bit.
6 years, 10 months ago (2014-02-10 11:47:48 UTC) #10
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 10 months ago (2014-02-10 17:48:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/143333008/70001
6 years, 10 months ago (2014-02-10 17:51:17 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 19:55:37 UTC) #13
Message was sent while issue was closed. 
Change committed as 250184

Powered by Google App Engine
This is Rietveld 408576698