Issue 14333009: D-Bus: allow multiple signal handlers for a signal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14333009: D-Bus: allow multiple signal handlers for a signal (Closed)

Created:
7 years, 8 months ago by keybuk

Modified:
7 years, 8 months ago

Reviewers:
satorux1

CC:
chromium-reviews, deymo

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

D-Bus: allow multiple signal handlers for a signal For the org.freedesktop.DBus.Properties.PropertyChanged signal, all relevant clients will share a single ObjectProxy since they share the same path and interface; the actual destination client for the signal is determined by its arguments. This means that we must support multiple signal handlers for a single object proxy, the previous fix of replacing with the latest was not sufficient for this case. Due to issue 223483, this is not a complete fix. Property objects coming and going will leave signal handlers in the ObjectProxy with NULLd weak pointer references - they will be harmless, but use up memory. BUG=234380 TEST=dbus_unittests R=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195953

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -27 lines)			Patch
M	dbus/end_to_end_async_unittest.cc	View	2 chunks	+19 lines, -19 lines	0 comments	Download
M	dbus/object_proxy.h	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	dbus/object_proxy.cc	View	3 chunks	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

keybuk

7 years, 8 months ago (2013-04-24 00:12:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r195953 (presubmit successful).

Expand Messages | Collapse Messages