extensions/renderer/api_activity_logger.cc - Issue 1433293004: [Extensions] Don't allow gin::Define to be overridden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_activity_logger.cc

Issue 1433293004: [Extensions] Don't allow gin::Define to be overridden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/bindings/override_gin_define.html ('k') | extensions/renderer/blob_native_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/api_activity_logger.cc

diff --git a/extensions/renderer/api_activity_logger.cc b/extensions/renderer/api_activity_logger.cc

index 826abb0c89daee41eecd0261a1a62fd68d8ecafb..f92ce530093f3f2bd8dd64180a5bd0cb25e0713e 100644

--- a/extensions/renderer/api_activity_logger.cc

+++ b/extensions/renderer/api_activity_logger.cc

@@ -38,10 +38,10 @@ void APIActivityLogger::LogEvent(

void APIActivityLogger::LogInternal(

const CallType call_type,

const v8::FunctionCallbackInfo<v8::Value>& args) {

- DCHECK_GT(args.Length(), 2);

- DCHECK(args[0]->IsString());

- DCHECK(args[1]->IsString());

- DCHECK(args[2]->IsArray());

+ CHECK_GT(args.Length(), 2);

+ CHECK(args[0]->IsString());

+ CHECK(args[1]->IsString());

+ CHECK(args[2]->IsArray());

std::string ext_id = *v8::String::Utf8Value(args[0]);

ExtensionHostMsg_APIActionOrEvent_Params params;