[Extensions] Don't allow gin::Define to be overridden

extensions/renderer/v8_helpers.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_V8_HELPERS_H_
 #define EXTENSIONS_RENDERER_V8_HELPERS_H_
 
 #include <string.h>
 
 #include "v8/include/v8.h"
@@ skipping 38 matching lines @@
 // Returns true if |maybe| is both a value, and that value is true.
 inline bool IsTrue(v8::Maybe<bool> maybe) {
   return maybe.IsJust() && maybe.FromJust();
 }
 
 // Returns true if |value| is empty or undefined.
 inline bool IsEmptyOrUndefied(v8::Local<v8::Value> value) {
   return value.IsEmpty() || value->IsUndefined();
 }
 
-// SetProperty() family wraps V8::Object::Set(). Returns true on success.
+// SetProperty() family wraps V8::Object::DefineOwnProperty().
+// Returns true on success.
 inline bool SetProperty(v8::Local<v8::Context> context,
                         v8::Local<v8::Object> object,
-                        v8::Local<v8::Value> key,
+                        v8::Local<v8::String> key,
                         v8::Local<v8::Value> value) {
-  return IsTrue(object->Set(context, key, value));
+  return IsTrue(object->DefineOwnProperty(context, key, value));
 }
 
 inline bool SetProperty(v8::Local<v8::Context> context,
                         v8::Local<v8::Object> object,
                         uint32_t index,
                         v8::Local<v8::Value> value) {
   return IsTrue(object->Set(context, index, value));

[Devlin, 2015/11/12 23:10:15]

Is there a way to bypass setters for an index-based set property?

[jochen (gone - plz use gerrit), 2015/11/12 23:17:37]

DefineOwnProperty should work for indexed values as well (just convert the
integer to a string)

[Devlin, 2015/11/12 23:40:48]

Oh, cool.  I wasn't sure if that's what it meant by indexed, or if it like
looped over it's existing properties and inserted one.

Updated.

 }
 
 inline bool SetProperty(v8::Local<v8::Context> context,
                         v8::Local<v8::Object> object,
                         const char* key,
                         v8::Local<v8::Value> value) {
   v8::Local<v8::String> v8_key;
   if (!ToV8String(context->GetIsolate(), key, &v8_key))
     return false;
   return SetProperty(context, object, v8_key, value);
@@ skipping 44 matching lines @@
                          int argc,
                          v8::Local<v8::Value> argv[],
                          v8::Local<v8::Value>* out) {
   return function->Call(context, recv, argc, argv).ToLocal(out);
 }
 
 }  // namespace v8_helpers
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_V8_HELPERS_H_