third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp - Issue 1433253003: [Line Layout API] Convert AbstractInlineTextBox to new line layout API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

Issue 1433253003: [Line Layout API] Convert AbstractInlineTextBox to new line layout API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp ('K') | « third_party/WebKit/Source/core/layout/line/InlineTextBox.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp b/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

index 33151698881cb7600568a2304d5496b44671a509..1e9cb91f5046551ba31c40147158ed262aaeea19 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

@@ -31,6 +31,7 @@

#include "core/dom/Range.h"

#include "core/layout/LayoutText.h"

+#include "core/paint/LineLayoutPaintShim.h"

#include "modules/accessibility/AXObjectCacheImpl.h"

#include "platform/LayoutUnit.h"

@@ -126,7 +127,7 @@ AXObject* AXInlineTextBox::computeParent() const

if (!m_inlineTextBox || !m_axObjectCache)

return 0;

- LayoutText* layoutText = m_inlineTextBox->layoutText();

+ LayoutText* layoutText = toLayoutText(LineLayoutPaintShim::layoutObjectFrom(m_inlineTextBox->lineLayoutItem()));

leviw_travelin_and_unemployed 2015/11/13 21:29:04 I don't particularly like the idea of using this e

return m_axObjectCache->getOrCreate(layoutText);

}

« third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp ('K') | « third_party/WebKit/Source/core/layout/line/InlineTextBox.h ('k') | no next file » | no next file with comments »