[Line Layout API] Convert AbstractInlineTextBox to new line layout API

[Line Layout API] Convert AbstractInlineTextBox to new line layout API

This affects AXInlineTextBox, which previously was the only caller to
AbstractInlineTextBox::layoutText(), and is now the only caller to
AbstractInlineTextBox::lineLayoutItem().

This also affects InlineTextBox, in the sense that AbstractInlineTextBox
was the last remaining caller to InlineTextBox::layoutObject(), which
is now removed.

BUG=499321
Committed: https://crrev.com/24f1ae8c7c39f5bd7e03310b91c26b4ce1f93a3f
Cr-Commit-Position: refs/heads/master@{#363853}

[pilgrim_google, 2015-11-11 17:29:14]

pilgrim@chromium.org changed reviewers:
+ eae@chromium.org, jsbell@chromium.org, leviw@chromium.org, ojan@chromium.org

[leviw_travelin_and_unemployed, 2015-11-13 21:29:04]

https://codereview.chromium.org/1433253003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp
(right):

https://codereview.chromium.org/1433253003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp:42:
PassRefPtr<AbstractInlineTextBox>
AbstractInlineTextBox::getOrCreate(LineLayoutText lineLayoutItem, InlineTextBox*
inlineTextBox)
s/lineLayoutItem/lineLayoutText/

https://codereview.chromium.org/1433253003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp:84:
m_lineLayoutItem.detach();
Do we need a detach method? If you assign it to nullptr will the compiler not
use the LineLayoutText(std::nullptr_t) constructor?

https://codereview.chromium.org/1433253003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
(right):

https://codereview.chromium.org/1433253003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp:130:
LayoutText* layoutText =
toLayoutText(LineLayoutPaintShim::layoutObjectFrom(m_inlineTextBox->lineLayoutItem()));
I don't particularly like the idea of using this elsewhere. If we do, we need to
take the paint part out.

[jsbell, 2015-11-19 22:08:27]

Drive-by...

https://codereview.chromium.org/1433253003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp
(right):

https://codereview.chromium.org/1433253003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp:85:
m_inlineTextBox = 0;
Change this `= 0` to `= nullptr` while you're here?

[pilgrim_google, 2015-12-07 15:27:00]

Description was changed from

==========
[Line Layout API] Convert AbstractInlineTextBox to new line layout API

This affects AXInlineTextBox, which previously was the only caller to
AbstractInlineTextBox::layoutText(), and is now the only caller to
AbstractInlineTextBox::lineLayoutItem().

This also affects InlineTextBox, in the sense that AbstractInlineTextBox
was the last remaining caller to InlineTextBox::layoutObject(), which
is now gone.

BUG=499321
==========

to

==========
[Line Layout API] Convert AbstractInlineTextBox to new line layout API

This affects AXInlineTextBox, which previously was the only caller to
AbstractInlineTextBox::layoutText(), and is now the only caller to
AbstractInlineTextBox::lineLayoutItem().

This also affects InlineTextBox, in the sense that AbstractInlineTextBox
was the last remaining caller to InlineTextBox::layoutObject(), which
is now entirely private (and can be removed).

BUG=499321
==========

[pilgrim_google, 2015-12-07 15:27:11]

Major update. Please re-review.

[leviw_travelin_and_unemployed, 2015-12-07 18:50:27]

https://codereview.chromium.org/1433253003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/line/InlineTextBox.h (right):

https://codereview.chromium.org/1433253003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/line/InlineTextBox.h:55: LayoutText&
layoutObject() const { return toLayoutText(InlineBox::layoutObject()); }
If this can be removed, can we take it out in this patch? :)

[pilgrim_google, 2015-12-07 20:19:06]

On 2015/12/07 at 18:50:27, leviw wrote:
>
https://codereview.chromium.org/1433253003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/layout/line/InlineTextBox.h (right):
> 
>
https://codereview.chromium.org/1433253003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/line/InlineTextBox.h:55: LayoutText&
layoutObject() const { return toLayoutText(InlineBox::layoutObject()); }
> If this can be removed, can we take it out in this patch? :)

Removed in patch 4.

[leviw_travelin_and_unemployed, 2015-12-07 21:12:15]

Woohoo!

LGTM. Please mention that you're removing it in the description (instead of "can
be removed")

[pilgrim_google, 2015-12-07 21:15:52]

Description was changed from

==========
[Line Layout API] Convert AbstractInlineTextBox to new line layout API

This affects AXInlineTextBox, which previously was the only caller to
AbstractInlineTextBox::layoutText(), and is now the only caller to
AbstractInlineTextBox::lineLayoutItem().

This also affects InlineTextBox, in the sense that AbstractInlineTextBox
was the last remaining caller to InlineTextBox::layoutObject(), which
is now entirely private (and can be removed).

BUG=499321
==========

to

==========
[Line Layout API] Convert AbstractInlineTextBox to new line layout API

This affects AXInlineTextBox, which previously was the only caller to
AbstractInlineTextBox::layoutText(), and is now the only caller to
AbstractInlineTextBox::lineLayoutItem().

This also affects InlineTextBox, in the sense that AbstractInlineTextBox
was the last remaining caller to InlineTextBox::layoutObject(), which
is now removed.

BUG=499321
==========

[pilgrim_google, 2015-12-07 21:15:57]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2015-12-07 21:18:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1433253003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1433253003/60001

[commit-bot: I haz the power, 2015-12-07 22:40:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 22:40:02]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pilgrim_google, 2015-12-08 02:06:26]

pilgrim@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[pilgrim_google, 2015-12-08 02:06:26]

pilgrim@chromium.org changed required reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2015-12-08 19:50:27]

lgtm

[pilgrim_google, 2015-12-08 19:50:48]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2015-12-08 19:51:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1433253003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1433253003/60001

[commit-bot: I haz the power, 2015-12-09 00:43:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-09 00:44:47]

Description was changed from

==========
[Line Layout API] Convert AbstractInlineTextBox to new line layout API

This affects AXInlineTextBox, which previously was the only caller to
AbstractInlineTextBox::layoutText(), and is now the only caller to
AbstractInlineTextBox::lineLayoutItem().

This also affects InlineTextBox, in the sense that AbstractInlineTextBox
was the last remaining caller to InlineTextBox::layoutObject(), which
is now removed.

BUG=499321
==========

to

==========
[Line Layout API] Convert AbstractInlineTextBox to new line layout API

This affects AXInlineTextBox, which previously was the only caller to
AbstractInlineTextBox::layoutText(), and is now the only caller to
AbstractInlineTextBox::lineLayoutItem().

This also affects InlineTextBox, in the sense that AbstractInlineTextBox
was the last remaining caller to InlineTextBox::layoutObject(), which
is now removed.

BUG=499321

Committed: https://crrev.com/24f1ae8c7c39f5bd7e03310b91c26b4ce1f93a3f
Cr-Commit-Position: refs/heads/master@{#363853}
==========

[commit-bot: I haz the power, 2015-12-09 00:44:48]

Patchset 4 (id:??) landed as
https://crrev.com/24f1ae8c7c39f5bd7e03310b91c26b4ce1f93a3f
Cr-Commit-Position: refs/heads/master@{#363853}