Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1433243003: Background compilation work: (Closed)

Created:
5 years, 1 month ago by srdjan
Modified:
5 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Background compilation work: - Defer deoptimization from optimizing compiler to code installation in mutator thread. - Defer registration of field and leaf class dependency until code is installed in mutator thread. - Cleanup. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/4600d37dc19d25382094a98f3141a49d51b9560f

Patch Set 1 #

Patch Set 2 : d #

Patch Set 3 : g #

Patch Set 4 : d #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -24 lines) Patch
M runtime/vm/assembler_arm.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/compiler.h View 2 chunks +13 lines, -0 lines 0 comments Download
M runtime/vm/compiler.cc View 1 2 3 13 chunks +128 lines, -16 lines 0 comments Download
M runtime/vm/flow_graph.h View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/heap.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object.h View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 11 chunks +12 lines, -1 line 0 comments Download
M tests/language/vm/load_elimination_any_use_creates_alias_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/load_elimination_has_loads_from_place_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/load_elimination_mark_stored_values_escaping_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/load_elimination_two_redefinitions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/optimized_stacktrace_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
5 years, 1 month ago (2015-11-11 22:19:39 UTC) #3
siva
lgtm
5 years, 1 month ago (2015-11-12 18:53:15 UTC) #4
srdjan
5 years, 1 month ago (2015-11-12 19:26:09 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
4600d37dc19d25382094a98f3141a49d51b9560f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698