Pass -marm when building with ASan for Android/ARM.

Pass -marm when building with ASan for Android/ARM.

Frame pointers are broken in Thumb mode.
The same reason as in 'profiling' condition several lines above.
FTR, http://llvm.org/bugs/show_bug.cgi?id=18505

BUG=325685
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246568

[Alexander Potapenko, 2014-01-22 12:22:42]

Rubberstamp LGTM if you're sure this works for the whole Chrome.

On Wed, Jan 22, 2014 at 4:15 PM,  <eugenis@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Pass -marm when building with ASan for Android/ARM.
>
> Frame pointers are broken in Thumb mode.
> The same reason as in 'profiling' condition several lines above.
> FTR, http://llvm.org/bugs/show_bug.cgi?id=18505
>
> BUG=325685
>
> Please review this at https://codereview.chromium.org/143323010/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+5, -0 lines):
>   M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index
>
bb6404482744d8022d0a6adf0fe0b67adb92a2d1..71688371de4bac4ce9dde3eaaf06d89405b210af
> 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -3283,6 +3283,11 @@
>                            '-fuse-ld=gold',
>                          ],
>                        }],
> +                      ['asan==1', {
> +                        'cflags': [
> +                          '-marm', # Required for frame pointer based stack
> traces.
> +                        ],
> +                      }],
>                      ],
>                    }],
>                  ],
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[eugenis, 2014-01-22 13:08:19]

On 2014/01/22 12:22:42, Alexander Potapenko wrote:
> Rubberstamp LGTM if you're sure this works for the whole Chrome.

Verified that it builds content_shell and runs
contentshell_instrumentation_tests successfully.

There is a bunch of moderately scary assembler warnings:

/tmp/gpu_data_manager_impl_private-e45116.s: Assembler messages:
/tmp/gpu_data_manager_impl_private-e45116.s:62063: Warning: source register same
as write-back base

Internets say that these are OK.

[commit-bot: I haz the power, 2014-01-23 08:21:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eugenis@chromium.org/143323010/1

[commit-bot: I haz the power, 2014-01-23 11:07:59]

Change committed as 246568