runtime/vm/dart_api_impl_test.cc - Issue 14332002: Add endian parameter to the get/set functions in ByteData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 14332002: Add endian parameter to the get/set functions in ByteData. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl_test.cc

===================================================================

--- runtime/vm/dart_api_impl_test.cc (revision 21661)

+++ runtime/vm/dart_api_impl_test.cc (working copy)

@@ -981,14 +981,14 @@

" var a = createExternalByteData();"

" Expect.equals(length, a.lengthInBytes);"

" for (int i = 0; i < length; i+=2) {"

- " Expect.equals(0x4241, a.getInt16(i));"

+ " Expect.equals(0x4241, a.getInt16(i, Endianness.LITTLE_ENDIAN));"

" }"

" for (int i = 0; i < length; i+=2) {"

" a.setInt8(i, 0x24);"

" a.setInt8(i + 1, 0x28);"

" }"

" for (int i = 0; i < length; i+=2) {"

- " Expect.equals(0x2824, a.getInt16(i));"

+ " Expect.equals(0x2824, a.getInt16(i, Endianness.LITTLE_ENDIAN));"

" }"

" return a;"

"}\n";

« no previous file with comments | « runtime/vm/bootstrap_natives.h ('k') | sdk/lib/typeddata/typeddata.dart » ('j') | sdk/lib/typeddata/typeddata.dart » ('J')