Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1433193003: [turbofan] Add support for fast elements access to sloppy/strict arguments. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for fast elements access to sloppy/strict arguments. Extend the element access specialization to also allow non-JSArray fast packed elements, which now includes unaliased sloppy and strict arguments. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/8a20d2b7dd1b3a3e1d39871267e0bc351b2c7c3b Cr-Commit-Position: refs/heads/master@{#31943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M src/compiler/access-info.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 3 chunks +19 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-11 12:29:20 UTC) #1
Jarin
lgtm
5 years, 1 month ago (2015-11-11 12:37:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433193003/1
5 years, 1 month ago (2015-11-11 12:59:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 13:00:37 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 13:01:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a20d2b7dd1b3a3e1d39871267e0bc351b2c7c3b
Cr-Commit-Position: refs/heads/master@{#31943}

Powered by Google App Engine
This is Rietveld 408576698