Generate Mojom Types for Dart

mojo/public/interfaces/bindings/mojom_files.mojom

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-[JavaPackage="org.chromium.mojo.bindings.types"]
-module mojo.bindings.types;
+[DartPackage="mojo", JavaPackage="org.chromium.mojo"]
+module mojo;

[azani, 2015/11/20 20:17:59]

Can you give me a pointer to where I should look in order to see what makes this
necessary?

Also maybe add a TODO?

[alexfandrianto, 2015/11/21 03:58:34]

It's not very simple to explain, but I will try. zra or Cutch can clarify.

The problem is that Dart also builds something called the 'embedder'.
https://github.com/domokit/mojo/blob/master/mojo/dart/embedder/BUILD.gn

In this BUILD rule it copies over the *.mojom.dart files from application,
bindings, and core to something called the dart_embedder_packages in
"out/Debug/gen/dart_embedder_packages/mojo/mojo". Unfortunately, the copying
(and path amending) is done in a simple fashion. Even if some .mojom files are
supposed to be generated in a subfolder, they won't get copied over correctly.

We determined that since the embedder is supposed to disappear soon, it is more
straightforward to temporarily change this module name, and change it back once
the embedder issues go away.

I will add a TODO for that. Is it okay to create an issue even though this CL is
still in-progress?

 
 import "mojom_types.mojom";
 
 /*
 * The structures in this file are intended to be used by the Mojom compiler
 * and code generators. The front end of the compiler takes as input a
 * .mojom file (or a list of .mojom files) and produces a MojomFileGraph struct.
 *
 * The backend of the compiler consumes a MojomFileGraph and invokes each of the
 * code generators passing them data derived from the MojomFileGraph.
@@ skipping 60 matching lines @@
   array<string>? structs;
   array<string>? unions;
   array<string>? top_level_enums;
   array<string>? embedded_enums;
 
   // All the constant_keys known to the owning MojomFileGraph.
   array<string>? top_level_constants;
   array<string>? embedded_constants;
 };