Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1433133003: [runtime] Make elements backing store for arguments non-holey. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Make elements backing store for arguments non-holey. Change sloppy and strict arguments objects to FAST_ELEMENTS for their backing stores, which will allow us to optimize them easier. Also fixes a bug in the elements accessors that was triggered by this change. R=verwaest@chromium.org Committed: https://crrev.com/d49bb69a5e327298157079adc8a301e9829fb7a5 Cr-Commit-Position: refs/heads/master@{#31942}

Patch Set 1 #

Patch Set 2 : Fix another case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M src/bootstrapper.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/elements.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/objects.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-11 09:58:04 UTC) #1
Benedikt Meurer
Hey Toon, This is the change we were working. Please take a look. Thanks, Benedikt
5 years, 1 month ago (2015-11-11 10:00:17 UTC) #2
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-11 11:49:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433133003/20001
5 years, 1 month ago (2015-11-11 11:54:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-11 12:08:30 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 12:08:55 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d49bb69a5e327298157079adc8a301e9829fb7a5
Cr-Commit-Position: refs/heads/master@{#31942}

Powered by Google App Engine
This is Rietveld 408576698