Source/core/dom/URLUtils.idl - Issue 143313002: Implement URLSearchParams.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/dom/URLUtils.idl

Issue 143313002: Implement URLSearchParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Handle dependency between URLUtils interfaces and URLSearchParams Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 22 matching lines...) Expand all Loading...
33	33

34 readonly attribute DOMString origin;	34 readonly attribute DOMString origin;

35 attribute DOMString protocol;	35 attribute DOMString protocol;

36 attribute DOMString username;	36 attribute DOMString username;

37 attribute DOMString password;	37 attribute DOMString password;

38 attribute DOMString host;	38 attribute DOMString host;

39 attribute DOMString hostname;	39 attribute DOMString hostname;

40 attribute DOMString port;	40 attribute DOMString port;

41 attribute DOMString pathname;	41 attribute DOMString pathname;

42 attribute DOMString search;	42 attribute DOMString search;

43	43 attribute URLSearchParams? searchParams;
	Inactive 2014/01/21 15:25:58 Why mark it as nullable if it cannot be null? (at Why mark it as nullable if it cannot be null? (at least according to your implementation. It makes the implementation a bit more complex for no reason. sof 2014/01/21 21:16:47 Yes, the query object cannot be null here, so leav Show quoted text On 2014/01/21 15:25:58, Chris Dumez wrote: > Why mark it as nullable if it cannot be null? (at least according to your > implementation. It makes the implementation a bit more complex for no reason. Yes, the query object cannot be null here, so leave out the unneeded generality.
44 // Not yet implemented.

45 // attribute URLQuery? query;

46

47 attribute DOMString hash;	44 attribute DOMString hash;

48 };	45 };

49	46

OLD	NEW

« Source/core/dom/URLSearchParams.idl ('K') | « Source/core/dom/URLSearchParams.idl ('k') | Source/core/html/HTMLAnchorElement.h » ('j') | no next file with comments »