third_party/WebKit/Source/web/TextFinder.cpp - Issue 1433103002: Use FocusParams in FocusController::setFocusedElement and Document::setFocusedElement arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/TextFinder.cpp

Issue 1433103002: Use FocusParams in FocusController::setFocusedElement and Document::setFocusedElement arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/TextFinder.cpp

diff --git a/third_party/WebKit/Source/web/TextFinder.cpp b/third_party/WebKit/Source/web/TextFinder.cpp

index c7bf5df78082fb3b81d86ccfc523f9d678440ed5..3bef0a99e12212414bf51b313653feaebd2f8df5 100644

--- a/third_party/WebKit/Source/web/TextFinder.cpp

+++ b/third_party/WebKit/Source/web/TextFinder.cpp

@@ -169,7 +169,7 @@ bool TextFinder::find(int identifier, const WebString& searchText, const WebFind

mainFrameImpl->ensureTextFinder().m_currentActiveMatchFrame = &ownerFrame();

// Make sure no node is focused. See http://crbug.com/38700.

- ownerFrame().frame()->document()->setFocusedElement(nullptr);

+ ownerFrame().frame()->document()->clearFocusedElement();

if (!options.findNext || activeSelection) {

// This is either a Find operation or a Find-next from a new start point

@@ -630,7 +630,7 @@ int TextFinder::selectFindMatch(unsigned index, WebRect* selectionRect)

ownerFrame().frame()->selection().clear();

// Make sure no node is focused. See http://crbug.com/38700.

- ownerFrame().frame()->document()->setFocusedElement(nullptr);

+ ownerFrame().frame()->document()->clearFocusedElement();

}

IntRect activeMatchRect;