Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1433103002: Use FocusParams in FocusController::setFocusedElement and Document::setFocusedElement arguments. (Closed)

Created:
5 years, 1 month ago by tkent
Modified:
5 years, 1 month ago
Reviewers:
kochi
CC:
aboxhall, aboxhall+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, dmazzoni, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, eae+blinkwatch, je_julie, nektar+watch_chromium.org, nektarios, plundblad+watch_chromium.org, rwlbuis, sof, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FocusParams in FocusController::setFocusedElement and Document::setFocusedElement arguments. Adds a FocusController::setFocusedElement overload and Document::clearFocusedElement to simplify the code. These functions receive unused SelectionBehaviorOnFocus as a member of FocusParams. We'll start to use SelectionBehaviorOnFocus in these functions later. This CL introduces SelectionBehaviorOnFocus::None for setFocusedElement callsites other than Element::focus. This CL has no behavior changes. BUG=526516 Committed: https://crrev.com/99a0f4166c156b1bcd64ffd8b04a087a311175d3 Cr-Commit-Position: refs/heads/master@{#359073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -50 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 10 chunks +17 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDialogElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/RadioInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.h View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.cpp View 6 chunks +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/TextFinder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
kochi@, would you review this please? My plan is to move updateFocusAppearance(SelectionBehaviorOnFocus) from Element::focus to ...
5 years, 1 month ago (2015-11-11 01:54:28 UTC) #3
kochi
lgtm
5 years, 1 month ago (2015-11-11 08:07:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433103002/1
5 years, 1 month ago (2015-11-11 08:11:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 09:21:42 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 09:22:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99a0f4166c156b1bcd64ffd8b04a087a311175d3
Cr-Commit-Position: refs/heads/master@{#359073}

Powered by Google App Engine
This is Rietveld 408576698