Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/win/message_compiler.py

Issue 1433093002: Roll buildtools 4a95614772..3ba3ca22ec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/allocator/prep_libc.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/win/message_compiler.py
diff --git a/build/win/message_compiler.py b/build/win/message_compiler.py
index 5e52efe8ca871e1ec29aa13243083c9758f2f286..86aba4f93009f0a8cee7c1eee3deaf2962ddc1c2 100644
--- a/build/win/message_compiler.py
+++ b/build/win/message_compiler.py
@@ -18,9 +18,11 @@ env_dict = dict([item.split('=', 1) for item in env_pairs])
# mc writes to stderr, so this explicitly redirects to stdout and eats it.
try:
+ # This needs shell=True to search the path in env_dict for the mc executable.
subprocess.check_output(["mc.exe"] + sys.argv[2:],
env=env_dict,
- stderr=subprocess.STDOUT)
+ stderr=subprocess.STDOUT,
+ shell=True)
except subprocess.CalledProcessError as e:
print e.output
sys.exit(e.returncode)
« no previous file with comments | « base/allocator/prep_libc.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698