Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1433093002: Roll buildtools 4a95614772..3ba3ca22ec (Closed)

Created:
5 years, 1 month ago by brettw
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 4a95614772..3ba3ca22ec In order to roll GN c51453e958..d6763a7390 (r358852:r358968) and pick up the following changes: d6763a7 Support script response files in GN. 9eca8d0 include what you use: errno.h in exec_process.cc Adds shell=True to the message compiler wrapper script. This is required for the new way that GN sets the environment on actions, and matches how it used to run (gyp-win-tool used to set this). Do the same plus set the environment for the prep_libc step. TBR=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel Committed: https://crrev.com/46c86d0ba1f6bf1abea78629ccb099eb8285ea7e Cr-Commit-Position: refs/heads/master@{#359365}

Patch Set 1 #

Patch Set 2 : mergey-wergey #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/allocator/BUILD.gn View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M base/allocator/prep_libc.py View 1 2 3 3 chunks +23 lines, -6 lines 0 comments Download
M build/win/message_compiler.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 29 (15 generated)
brettw
5 years, 1 month ago (2015-11-11 00:29:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433093002/1
5 years, 1 month ago (2015-11-11 00:33:21 UTC) #3
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-11 00:34:51 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/65011)
5 years, 1 month ago (2015-11-11 02:05:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433093002/20001
5 years, 1 month ago (2015-11-11 21:25:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/121311) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 1 month ago (2015-11-11 21:35:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433093002/20001
5 years, 1 month ago (2015-11-11 21:42:07 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/87131)
5 years, 1 month ago (2015-11-11 22:13:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433093002/20001
5 years, 1 month ago (2015-11-11 22:18:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433093002/40001
5 years, 1 month ago (2015-11-11 22:44:07 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/65526)
5 years, 1 month ago (2015-11-12 00:07:36 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433093002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433093002/60001
5 years, 1 month ago (2015-11-12 17:57:35 UTC) #27
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-12 20:11:47 UTC) #28
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:12:41 UTC) #29
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/46c86d0ba1f6bf1abea78629ccb099eb8285ea7e
Cr-Commit-Position: refs/heads/master@{#359365}

Powered by Google App Engine
This is Rietveld 408576698