Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1433043002: add a few OWNERS files below tools/ (Closed)

Created:
5 years, 1 month ago by Nico
Modified:
5 years, 1 month ago
CC:
aboxhall+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, plundblad+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add a few OWNERS files below tools/ BUG=none Committed: https://crrev.com/f841024ad8594dfcdffb9a5285920d0ceeff84fc Cr-Commit-Position: refs/heads/master@{#358909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
A + tools/accessibility/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/cfi/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A + tools/linux/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
A + tools/mac/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
A + tools/security/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
A tools/vim/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
Nico
dmazzoni, dtseng: tools/accessibility krasin, pcc: tools/cfi thestig, thakis: tools/linux and tools/mac ('cause it's morally identical ...
5 years, 1 month ago (2015-11-10 19:24:39 UTC) #2
pcc1
LGTM for tools/cfi
5 years, 1 month ago (2015-11-10 19:26:35 UTC) #3
eroman
lgtm
5 years, 1 month ago (2015-11-10 19:27:06 UTC) #4
asanka
lgtm
5 years, 1 month ago (2015-11-10 19:30:46 UTC) #5
scottmg
lgtm
5 years, 1 month ago (2015-11-10 19:31:10 UTC) #6
dmazzoni
lgtm
5 years, 1 month ago (2015-11-10 19:32:30 UTC) #7
Tom Sepez
lgtm
5 years, 1 month ago (2015-11-10 19:33:19 UTC) #8
Lei Zhang
not last lgtm
5 years, 1 month ago (2015-11-10 20:11:39 UTC) #9
Nico
Got at least one from each file, will cq+ On Nov 10, 2015 12:11 PM, ...
5 years, 1 month ago (2015-11-10 21:36:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433043002/1
5 years, 1 month ago (2015-11-10 21:36:56 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 21:42:18 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 21:43:20 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f841024ad8594dfcdffb9a5285920d0ceeff84fc
Cr-Commit-Position: refs/heads/master@{#358909}

Powered by Google App Engine
This is Rietveld 408576698