Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1832)

Issue 1433033002: simplify the is_desktop_linux default value expression (Closed)

Created:
5 years, 1 month ago by Mostyn Bramley-Moore
Modified:
5 years, 1 month ago
Reviewers:
smcgruer2, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

simplify the is_desktop_linux default value expression Let's remove the redundant '&& current_is != "chromeos"' part of the is_desktop_linux default value expression. BUG=554006 Committed: https://crrev.com/3e37ae536e06a91ce60869496db2b9b17f02c70a Cr-Commit-Position: refs/heads/master@{#358946}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Mostyn Bramley-Moore
@brettw: can you please rubber-stamp this? (Is the description OK?)
5 years, 1 month ago (2015-11-10 19:22:56 UTC) #3
brettw
lgtm
5 years, 1 month ago (2015-11-10 21:40:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433033002/1
5 years, 1 month ago (2015-11-10 22:15:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 23:16:08 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 23:17:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e37ae536e06a91ce60869496db2b9b17f02c70a
Cr-Commit-Position: refs/heads/master@{#358946}

Powered by Google App Engine
This is Rietveld 408576698