Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Issue 143303007: Enable pairing registry in me2me native messaging host on Windows (Closed)

Created:
6 years, 10 months ago by weitao
Modified:
6 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pairing
Visibility:
Public.

Description

Enable pairing registry in me2me native messaging host on Windows: 1. Build a standalone remoting_native_messaging_host.exe. remoting_host.exe is a win32 application (as opposed to console application) thus not suitable as a native messaging host. 2. Initialize the pairing registry reg keys in the native messaging host. 3. GetPairdClients doesn't require elevation. 4. Add the native messaging host binary and manifest and the pairing reg keys to the installer. Enable pairing registry in Me2Me native messaging host on Windows. BUG=325567 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251137

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -49 lines) Patch
M remoting/host/daemon_process_win.cc View 1 3 chunks +6 lines, -16 lines 0 comments Download
M remoting/host/installer/win/chromoting.wxs View 3 chunks +41 lines, -3 lines 0 comments Download
M remoting/host/pairing_registry_delegate_win.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_main.cc View 1 2 chunks +53 lines, -2 lines 0 comments Download
M remoting/remoting_host.gypi View 1 3 chunks +23 lines, -23 lines 0 comments Download
M remoting/remoting_host_win.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
weitao
PTAL
6 years, 10 months ago (2014-02-13 01:31:55 UTC) #1
Sergey Ulanov
LGTM once my comments are addressed https://codereview.chromium.org/143303007/diff/1/remoting/host/installer/win/chromoting.wxs File remoting/host/installer/win/chromoting.wxs (right): https://codereview.chromium.org/143303007/diff/1/remoting/host/installer/win/chromoting.wxs#newcode192 remoting/host/installer/win/chromoting.wxs:192: <File Id="remoting_native_messaging_host.exe" maybe ...
6 years, 10 months ago (2014-02-13 01:53:23 UTC) #2
weitao
https://codereview.chromium.org/143303007/diff/1/remoting/host/installer/win/chromoting.wxs File remoting/host/installer/win/chromoting.wxs (right): https://codereview.chromium.org/143303007/diff/1/remoting/host/installer/win/chromoting.wxs#newcode192 remoting/host/installer/win/chromoting.wxs:192: <File Id="remoting_native_messaging_host.exe" I prefer to keep the current name. ...
6 years, 10 months ago (2014-02-13 18:13:09 UTC) #3
weitao
The CQ bit was checked by weitaosu@chromium.org
6 years, 10 months ago (2014-02-13 18:13:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/143303007/80001
6 years, 10 months ago (2014-02-13 18:15:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/143303007/80001
6 years, 10 months ago (2014-02-13 19:56:24 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 21:47:46 UTC) #7
Message was sent while issue was closed.
Change committed as 251137

Powered by Google App Engine
This is Rietveld 408576698