Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Unified Diff: chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc

Issue 1433013004: Replace ScopedVector with vector<scoped_ptr> in BitmapFetcherService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: scopedvector-bitmapfetcher: no-find-fix-unittest Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc
diff --git a/chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc b/chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc
index 4cbc4b06e438d37c89857fb20d69bd181fcf669d..f4f780abe1ce8c8f28b63d058a800cc555bc3e11 100644
--- a/chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc
+++ b/chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc
@@ -42,8 +42,8 @@ class TestService : public BitmapFetcherService {
// Create a fetcher, but don't start downloading. That allows side-stepping
// the decode step, which requires a utility process.
- chrome::BitmapFetcher* CreateFetcher(const GURL& url) override {
- return new chrome::BitmapFetcher(url, this);
+ scoped_ptr<chrome::BitmapFetcher> CreateFetcher(const GURL& url) override {
+ return make_scoped_ptr(new chrome::BitmapFetcher(url, this));
}
};
@@ -66,7 +66,8 @@ class BitmapFetcherServiceTest : public testing::Test,
const ScopedVector<BitmapFetcherRequest>& requests() const {
return service_->requests_;
}
- const ScopedVector<chrome::BitmapFetcher>& active_fetchers() const {
+ const std::vector<scoped_ptr<chrome::BitmapFetcher>>& active_fetchers()
+ const {
return service_->active_fetchers_;
}
size_t cache_size() const { return service_->cache_.size(); }

Powered by Google App Engine
This is Rietveld 408576698