chrome/app/main_dll_loader_win.cc - Issue 1432973004: Transform ImagePreReader into PreReadFile (v2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/main_dll_loader_win.cc

Issue 1432973004: Transform ImagePreReader into PreReadFile (v2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Initial implementation, with grt comments addressed. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/app/main_dll_loader_win.cc

diff --git a/chrome/app/main_dll_loader_win.cc b/chrome/app/main_dll_loader_win.cc

index 4f831ff6bb5a9dea72cca67b1024cbeef5f92deb..ba14dba3bcc3cdb209ddf0a1ee79cb5f50530abe 100644

--- a/chrome/app/main_dll_loader_win.cc

+++ b/chrome/app/main_dll_loader_win.cc

@@ -26,7 +26,7 @@

#include "chrome/app/chrome_crash_reporter_client.h"

#include "chrome/app/chrome_watcher_client_win.h"

#include "chrome/app/chrome_watcher_command_line_win.h"

-#include "chrome/app/image_pre_reader_win.h"

+#include "chrome/app/file_pre_reader_win.h"

#include "chrome/app/kasko_client.h"

#include "chrome/chrome_watcher/chrome_watcher_main_api.h"

#include "chrome/common/chrome_constants.h"

@@ -63,9 +63,7 @@ HMODULE LoadModuleWithDirectory(const base::FilePath& module, bool pre_read) {

// We pre-read the binary to warm the memory caches (fewer hard faults to

// page parts of the binary in).

const size_t kStepSize = 1024 * 1024;

- size_t percent = 100;

- ImagePreReader::PartialPreReadImage(module.value().c_str(), percent,

- kStepSize);

+ PreReadFile(module, kStepSize);

}

return ::LoadLibraryExW(module.value().c_str(), nullptr,