Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 1432973002: Update the mDNS command line tools in the mdns package (Closed)

Created:
5 years, 1 month ago by Søren Gjesse
Modified:
5 years, 1 month ago
Reviewers:
wibling, karlklose
CC:
fletch+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/fletch.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update the mDNS command line tools in the mdns package Add a lookup tool. Add a timeout option to both tools. R=wibling@google.com, karlklose@google.com BUG= Committed: https://github.com/dart-lang/fletch/commit/791be3eb8a4ea461cd94bbb2b523458eed33bca2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -14 lines) Patch
A pkg/mdns/bin/mdns-resolve.dart View 1 chunk +38 lines, -0 lines 0 comments Download
M pkg/mdns/bin/mdns-sd.dart View 1 chunk +15 lines, -5 lines 0 comments Download
M pkg/mdns/lib/mdns.dart View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Søren Gjesse
5 years, 1 month ago (2015-11-10 10:22:13 UTC) #1
wibling
lgtm
5 years, 1 month ago (2015-11-10 14:35:42 UTC) #3
Søren Gjesse
5 years, 1 month ago (2015-11-10 14:41:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
791be3eb8a4ea461cd94bbb2b523458eed33bca2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698