content/common/gpu/media/vaapi_jpeg_decode_accelerator.h - Issue 1432963003: [Ozone] Extends the lifetime of VaapiWrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/vaapi_jpeg_decode_accelerator.h

Issue 1432963003: [Ozone] Extends the lifetime of VaapiWrapper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: NOT for upstream Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/vaapi_jpeg_decode_accelerator.h

diff --git a/content/common/gpu/media/vaapi_jpeg_decode_accelerator.h b/content/common/gpu/media/vaapi_jpeg_decode_accelerator.h

index acbf4273ccdfeb10eb01b4d9728a335e05d38045..ae1d8e296e6edaa2fb9d57f5ad0df88a2c79eff9 100644

--- a/content/common/gpu/media/vaapi_jpeg_decode_accelerator.h

+++ b/content/common/gpu/media/vaapi_jpeg_decode_accelerator.h

@@ -87,7 +87,7 @@ class CONTENT_EXPORT VaapiJpegDecodeAccelerator

// decoder thread to the ChildThread should use |weak_this_|.

base::WeakPtr<VaapiJpegDecodeAccelerator> weak_this_;

- scoped_ptr<VaapiWrapper> vaapi_wrapper_;

+ scoped_refptr<VaapiWrapper> vaapi_wrapper_;

Pawel Osciak 2015/11/16 04:24:35 Is this change required? This class doesn't use Va

william.xie1 2015/11/16 08:07:25 Dear Pawel, for compile error because of scoped_re

william.xie1 2015/11/16 08:07:25 Done.

// Comes after vaapi_wrapper_ to ensure its destructor is executed before

// |vaapi_wrapper_| is destroyed.