Check for metadata in PNaCl ABI checker.

test/NaCl/PNaClABI/types-function.ll

 ; RUN: pnacl-abicheck < %s | FileCheck %s
 ; Test type-checking in function bodies. This test is not intended to verify
 ; all the rules about the various types, but instead to make sure that types
 ; stashed in various places in function bodies are caught.
 
 @a2 = private global i17 zeroinitializer
 declare void @func(i15 %arg)
 
 !llvm.foo = !{!0}
 !0 = metadata !{ half 0.0}
 
 define void @types() {
 ; CHECK: Function types has instruction with disallowed type: half
   %h1 = fptrunc double undef to half
 ; CHECK: Function types has instruction operand with disallowed type: half
   %h2 = bitcast half 0.0 to i16
 ; see below...
   %h3 = fadd double 0.0, fpext (half 0.0 to double)
 
 ; TODO(mseaborn): Re-enable integer size checking.
 ; See https://code.google.com/p/nativeclient/issues/detail?id=3360
 ; C;HECK: Function types has instruction operand with disallowed type: i17*
 ;  store i32 0, i32* bitcast (i17* @a2 to i32*), align 4
 ; C;HECK: Function types has instruction operand with disallowed type: i15
 ;  call void @func(i15 1)
 
-; CHECK: Function types has instruction metadata containing disallowed type: half
+; CHECK: Function types has disallowed instruction metadata

[Mark Seaborn, 2013/04/25 18:04:32]

Change to "...metadata: !foo" to check reporting of metadata type?

[jvoung (off chromium), 2013/04/25 23:22:20]

Not sure what you mean?  What is "...metadata:" ?

[Mark Seaborn, 2013/04/25 23:25:50]

I meant you can change it to:
"; CHECK: Function types has disallowed instruction metadata: foo"

[jvoung (off chromium), 2013/04/26 16:51:29]

Done.

   ret void, !foo !0
 }
 ; CHECK-NOT: disallowed
 
 
 ; TODO:
 ; the bitcode reader seems to expand some operations inline
 ; (e.g. fpext, sext, uitofp) such that doing something like
 ;   %h3 = fadd double 0.0, fpext (half 0.0 to double)
 ; means the verifier pass will never see the fpext or its operands