third_party/libjingle/overrides/talk/base/logging.h - Issue 14329020: Implementing uploading of a WebRTC diagnostic log.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libjingle/overrides/talk/base/logging.h

Issue 14329020: Implementing uploading of a WebRTC diagnostic log. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Code review. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libjingle/overrides/talk/base/logging.h

diff --git a/third_party/libjingle/overrides/talk/base/logging.h b/third_party/libjingle/overrides/talk/base/logging.h

index 5203916023a0fcec24358e3cf95eacd0b130e918..994fa1b741283dbbda7584b31cb5219713c0bc8d 100644

--- a/third_party/libjingle/overrides/talk/base/logging.h

+++ b/third_party/libjingle/overrides/talk/base/logging.h

@@ -187,7 +187,9 @@ void InitDiagnosticLoggingDelegate(LogMessageDelegate* delegate);

#define LOG_V(sev) VLOG(sev)

#undef LOG

-#define LOG(sev) LOG_V(talk_base::sev)

+// TODO(grunell): Revert change. Only for testing.

+//#define LOG(sev) LOG_V(talk_base::sev)

+#define LOG(sev) DIAGNOSTIC_LOG(talk_base::sev)

// The _F version prefixes the message with the current function name.

#if defined(__GNUC__) && defined(_DEBUG)